[ML] Explain Log Rate Spikes: Fix loading state for grouping. #141770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
11 tasks
walterra
added
:ml
Feature:ML/AIOps
|
Pinging @elastic/ml-ui (:ml) |
darnautov
approved these changes
Sep 29, 2022
Comment on lines
+36
to
+46
| '::-webkit-progress-inner-element': { | ||
| overflow: 'hidden', | ||
| backgroundPosition: 'inherit', | ||
| }, | ||
| '::-webkit-progress-bar': { | ||
| backgroundColor: 'transparent', | ||
| backgroundPosition: 'inherit', | ||
| }, | ||
|
|
||
| '::-webkit-progress-value': progressBackground, | ||
| '::-moz-progress-bar': progressBackground, |
There was a problem hiding this comment.
if I get it right, emotion has an auto-prefixer emotion-js/emotion#1523.
did you try it?
There was a problem hiding this comment.
The autocomplete/types for the available attributes still falls back to these webkit/moz based ones. It could be because of the differences in names to make this work. I was able to clean up a little bit the other styles though in 77bca25.
qn895
approved these changes
Sep 30, 2022
|
Tested and LGTM 🎉 |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2022
…c#141770) Fix loading state messages for grouping: - Fixes the progress bar messages to include the grouping step. - If progress stalls, it might look to the user like the analysis got stuck when there are steps like the grouping that take a longer time. This updates the progress bar to show an animated background as long as the analysis is running. When the analysis finishes or gets canceled the animated background gets disabled and shows a static background. (cherry picked from commit 5203f1b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2022
… (#142445) Fix loading state messages for grouping: - Fixes the progress bar messages to include the grouping step. - If progress stalls, it might look to the user like the analysis got stuck when there are steps like the grouping that take a longer time. This updates the progress bar to show an animated background as long as the analysis is running. When the analysis finishes or gets canceled the animated background gets disabled and shows a static background. (cherry picked from commit 5203f1b) Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
…c#141770) Fix loading state messages for grouping: - Fixes the progress bar messages to include the grouping step. - If progress stalls, it might look to the user like the analysis got stuck when there are steps like the grouping that take a longer time. This updates the progress bar to show an animated background as long as the analysis is running. When the analysis finishes or gets canceled the animated background gets disabled and shows a static background.
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
…c#141770) Fix loading state messages for grouping: - Fixes the progress bar messages to include the grouping step. - If progress stalls, it might look to the user like the analysis got stuck when there are steps like the grouping that take a longer time. This updates the progress bar to show an animated background as long as the analysis is running. When the analysis finishes or gets canceled the animated background gets disabled and shows a static background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #141192.
Fix loading state messages for grouping.
Before:
After:
Checklist