141189 alerts table performance #141385
Merged
141189 alerts table performance #141385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcger
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
semd
reviewed
Sep 26, 2022
Comment on lines
+32
to
+40
| const getFieldCategoryFromColumnId = (columnId: string): string => { | ||
| const fieldName = columnId.split('.'); | ||
|
|
||
| if (fieldName.length === 1) { | ||
| return 'base'; | ||
| } | ||
|
|
||
| return fieldName[0]; | ||
| }; |
There was a problem hiding this comment.
I love this one, it simplifies the search to constant time 💯
The only exception to that criteria are runtime fields, but I don't think you have to deal with them on your side yet.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2022
* retrieve data without loops and work with columns instead of ids * not found column when category doesnt exist (cherry picked from commit 76b2624)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #141189