Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Alerts Table - improve populate columns performance #141189

Closed
jcger opened this issue Sep 21, 2022 · 1 comment · Fixed by #141385
Closed

[RAM] Alerts Table - improve populate columns performance #141189

jcger opened this issue Sep 21, 2022 · 1 comment · Fixed by #141385
Assignees
@jcger
Labels
Feature:Alerting/Alerts-as-Data Issues related to Alerts-as-data and RuleRegistry Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@jcger
Copy link
Contributor

jcger commented Sep 21, 2022

This issue is a follow up of a couple of comments that came up while implementing the Fields feature in the toolbar of the Alerts Table

#140516 (comment)
#140516 (comment)

Here we are doing an O(n*m) complexity search, for all columns and all fields (when calling getBrowserFieldProps). It could be improved to O(n), being n the number of fields in browserFields.

We want to improve the algorithm to populate the data grid columns with schema property.
@jcger jcger added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/Alerts-as-Data Issues related to Alerts-as-data and RuleRegistry labels Sep 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@jcger jcger changed the title [RAM] Alerts Table - [RAM] Alerts Table - improve populate columns performance Sep 21, 2022
@jcger jcger mentioned this issue Sep 22, 2022
Merged
@jcger jcger self-assigned this Sep 22, 2022
@jcger jcger moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Sep 22, 2022
@jcger jcger moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Sep 23, 2022
Repository owner moved this from In Review to Done in AppEx: ResponseOps - Rules & Alerts Management Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcger jcger

Labels
Feature:Alerting/Alerts-as-Data Issues related to Alerts-as-data and RuleRegistry Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

141189 alerts table performance jcger/kibana
2 participants
@elasticmachine @jcger