141119 remove visibility toogle + use_columns refactor #141250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcger
force-pushed
the
141119-remove-visibility-toogle
branch
from
0c5c6e0 to
41f4ace
Compare
jcger
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
jcger
changed the title
jcger
commented
Sep 22, 2022
| @@ -116,9 +120,6 @@ export const useColumns = ({ | |||
| }); | |||
| const [columns, setColumns] = useState<EuiDataGridColumn[]>(storageAlertsTable.current.columns); | |||
| const [isColumnsPopulated, setColumnsPopulated] = useState<boolean>(false); | |||
| const [visibleColumns, setVisibleColumns] = useState( | |||
There was a problem hiding this comment.
I was able to remove this state due to this refactor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
XavierM
added
bug
XavierM
approved these changes
Sep 22, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2022
* remove columns hide selector * refactor use_column hook * add testing * add getColumnIds fn (cherry picked from commit 10564ef)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #141119
Checklist
Delete any items that are not applicable to this PR.