Fix downsample validation when downsample action disappears from the previous phase

[Dosant]

Fix #140714

Problem

The PR for downsampling action was merged, but there is this validation edge case that bothers me:

You can enable Downsample action in hot, warm, and cold phases. You can configure downsampling interval. The interval has validation where it depends on the interval in the previous phase:

• they must be greater than any previous interval and a multiple of that interval.
  • For example, on the warm phase, the user includes a 3-hour interval; if they choose to add a rollup action on the cold phase, the interval must be a multiple of 3h. It cannot be 5h, for example.
  • Another example: a user can have a rollup on the hot phase of 2d and then no rollup action on the warm phase, and then a rollup action on the cold phase, but it must be a multiple of 2d, for example, it cannot be 1d nor can it be 3d.

There is currently the following bug that I struggle to fix:

• Enable Downsample in hot phase and set the interval to 1 day
• Enable Downsample in warm phase and set the interval to 1 day (see the error)
• Disable Downsample in hot phase (through the custom rollover option)
• See that the error in warm didn't disappear. The user needs to change the field to trigger validation

See the video:

validation.bug.mov

Solution

The proper fix ended up being inside the lib itself.
When a field was unmounted, the corresponding value was changed, but this didn't trigger the validation of dependant fields from fieldsToValidateOnChange.
The fix is to trigger validation of the fields from fieldsToValidateOnChange when a field is being unmounted.

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 75b4fcd

Failed CI Steps

• FTR Configs #3

Test Failures

• [job] [logs] FTR Configs #3 / Reporting Functional Tests with forced timeout adds a visual warning in the report output

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
esUiShared	152.6KB	152.6KB	+72.0B

History

• 💔 Build #72142 failed 5f85cba
• 💚 Build #71860 succeeded 7c1a00a2bd3795ae69cced2e5e4efb2647a7928b
• 💚 Build #71791 succeeded 1a5a0d70721d6db5f3ab4022960e5cff8ca14a38

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[sebelga]

LGTM! 👍 Thanks for fixing this issue @Dosant !

[alisonelizabeth]

Thanks for fixing this and updating the tests @Dosant! LGTM.