Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM][Downsample] Error is not reset when downsample action unmounts from the previous phase #140714

Closed
Dosant opened this issue Sep 14, 2022 · 2 comments · Fixed by #140628
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:ILM impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.5.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 14, 2022

The PR for downsampling action was merged, but there is this validation edge case:

You can enable Downsample action in hot, warm, and cold phases. You can configure downsampling intervals. The interval has validation where it depends on the interval in the previous phase:

image

  • they must be greater than any previous interval and a multiple of that interval.
    • For example, on the warm phase, the user includes a 3-hour interval; if they choose to add a rollup action on the cold phase, the interval must be a multiple of 3h. It cannot be 5h, for example.
    • Another example: a user can have a rollup on the hot phase of 2d and then no rollup action on the warm phase, and then a rollup action on the cold phase, but it must be a multiple of 2d, for example, it cannot be 1d nor can it be 3d.

image

There is currently the following bug:

  • Enable Downsample in hot phase and set the interval to 1 day
  • Enable Downsample in warm phase and set the interval to 1 day (see the error)
  • Disable Downsample in hot phase (through the custom rollover option)
  • See that the error in warm didn't disappear. The user needs to change the field to trigger validation

See the video:

validation.bug.mov
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:AppServicesUx v8.5.0 labels Sep 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:ILM impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants