Enable TSDB downsampling ILM configuration

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/downsample_interval.test.ts

@@ -0,0 +1,130 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { act } from 'react-dom/test-utils';
+import { i18nTexts } from '../../../../public/application/sections/edit_policy/i18n_texts';
+
+import { PhaseWithDownsample } from '../../../../common/types';
+import { setupEnvironment } from '../../helpers';
+import { setupValidationTestBed, ValidationTestBed } from './validation.helpers';
+
+describe('<EditPolicy /> downsample interval validation', () => {
+  let testBed: ValidationTestBed;
+  let actions: ValidationTestBed['actions'];
+  const { httpSetup, httpRequestsMockHelpers } = setupEnvironment();
+
+  beforeAll(() => {
+    jest.useFakeTimers();
+  });
+
+  afterAll(() => {
+    jest.useRealTimers();
+  });
+
+  beforeEach(async () => {
+    httpRequestsMockHelpers.setDefaultResponses();
+    httpRequestsMockHelpers.setLoadPolicies([]);
+
+    await act(async () => {
+      testBed = await setupValidationTestBed(httpSetup);
+    });
+
+    const { component } = testBed;
+    component.update();
+    ({ actions } = testBed);
+    await actions.setPolicyName('mypolicy');
+  });
+
+  [
+    {
+      name: `doesn't allow empty interval`,
+      value: '',
+      error: [i18nTexts.editPolicy.errors.numberRequired],
+    },
+    {
+      name: `doesn't allow 0 for interval`,
+      value: '0',
+      error: [i18nTexts.editPolicy.errors.numberGreatThan0Required],
+    },
+    {
+      name: `doesn't allow -1 for interval`,
+      value: '-1',
+      error: [i18nTexts.editPolicy.errors.numberGreatThan0Required],
+    },
+    {
+      name: `doesn't allow decimals for timing (with dot)`,
+      value: '5.5',
+      error: [i18nTexts.editPolicy.errors.integerRequired],
+    },
+    {
+      name: `doesn't allow decimals for timing (with comma)`,
+      value: '5,5',
+      error: [i18nTexts.editPolicy.errors.integerRequired],
+    },
+  ].forEach((testConfig: { name: string; value: string; error: string[] }) => {
+    (['hot', 'warm', 'cold'] as PhaseWithDownsample[]).forEach((phase: PhaseWithDownsample) => {
+      const { name, value, error } = testConfig;
+      test(`${phase}: ${name}`, async () => {
+        if (phase !== 'hot') {
+          await actions.togglePhase(phase);
+        }
+
+        await actions[phase].downsample.toggle();
+
+        // 1. We first set as dummy value to have a starting min_age value
+        await actions[phase].downsample.setDownsampleInterval('111');
+        // 2. At this point we are sure there will be a change of value and that any validation
+        // will be displayed under the field.
+        await actions[phase].downsample.setDownsampleInterval(value);
+
+        actions.errors.waitForValidation();
+
+        actions.errors.expectMessages(error);
+      });
+    });
+  });
+
+  test('should validate an interval is greater or multiple than previous phase interval', async () => {
+    await actions.togglePhase('warm');
+    await actions.togglePhase('cold');
+
+    await actions.hot.downsample.toggle();
+    await actions.hot.downsample.setDownsampleInterval('60', 'm');
+
+    await actions.warm.downsample.toggle();
+    await actions.warm.downsample.setDownsampleInterval('1', 'h');
+
+    actions.errors.waitForValidation();
+    actions.errors.expectMessages(
+      ['Must be greater than and a multiple of the hot phase value (60m)'],
+      'warm'
+    );
+
+    await actions.cold.downsample.toggle();
+    await actions.cold.downsample.setDownsampleInterval('90', 'm');
+    actions.errors.waitForValidation();
+    actions.errors.expectMessages(
+      ['Must be greater than and a multiple of the warm phase value (1h)'],
+      'cold'
+    );
+
+    // disable warm phase;
+    await actions.togglePhase('warm');
+    // TODO: there is a bug that disabling a phase doesn't trigger downsample validation in other phases,
+    // users can work around it by changing the value
+    await actions.cold.downsample.setDownsampleInterval('120', 'm');
+    actions.errors.waitForValidation();
+    actions.errors.expectMessages([], 'cold');
+
+    await actions.cold.downsample.setDownsampleInterval('90', 'm');
+    actions.errors.waitForValidation();
+    actions.errors.expectMessages(
+      ['Must be greater than and a multiple of the hot phase value (60m)'],
+      'cold'
+    );
+  });
+});

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts

@@ -201,6 +201,8 @@ describe('<EditPolicy /> serialization', () => {
       await actions.hot.setShrinkCount('2');
       await actions.hot.toggleReadonly();
       await actions.hot.setIndexPriority('123');
+      await actions.hot.downsample.toggle();
+      await actions.hot.downsample.setDownsampleInterval('2', 'h');
 
       await actions.savePolicy();
 
@@ -231,6 +233,7 @@ describe('<EditPolicy /> serialization', () => {
                     priority: 123,
                   },
                   readonly: {},
+                  downsample: { fixed_interval: '2h' },
                 },
               },
             },
@@ -323,6 +326,8 @@ describe('<EditPolicy /> serialization', () => {
       await actions.warm.setBestCompression(true);
       await actions.warm.toggleReadonly();
       await actions.warm.setIndexPriority('123');
+      await actions.warm.downsample.toggle();
+      await actions.warm.downsample.setDownsampleInterval('20', 'm');
       await actions.savePolicy();
 
       expect(httpSetup.post).toHaveBeenLastCalledWith(
@@ -360,6 +365,7 @@ describe('<EditPolicy /> serialization', () => {
                     number_of_replicas: 123,
                   },
                   readonly: {},
+                  downsample: { fixed_interval: '20m' },
                 },
               },
             },
@@ -463,6 +469,8 @@ describe('<EditPolicy /> serialization', () => {
       await actions.cold.setReplicas('123');
       await actions.cold.toggleReadonly();
       await actions.cold.setIndexPriority('123');
+      await actions.cold.downsample.toggle();
+      await actions.cold.downsample.setDownsampleInterval('5');
 
       await actions.savePolicy();
 
@@ -494,6 +502,7 @@ describe('<EditPolicy /> serialization', () => {
                     number_of_replicas: 123,
                   },
                   readonly: {},
+                  downsample: { fixed_interval: '5d' },
                 },
               },
             },

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/downsample_actions.ts

@@ -0,0 +1,44 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { TestBed } from '@kbn/test-jest-helpers';
+import { act } from 'react-dom/test-utils';
+import { Phase } from '../../../../common/types';
+import { createFormToggleAction } from '..';
+
+const createSetDownsampleIntervalAction =
+  (testBed: TestBed, phase: Phase) => async (value: string, units?: string) => {
+    const { find, component } = testBed;
+
+    await act(async () => {
+      find(`${phase}-downsampleFixedInterval`).simulate('change', { target: { value } });
+    });
+    component.update();
+
+    if (units) {
+      act(() => {
+        find(`${phase}-downsampleFixedIntervalUnits.show-filters-button`).simulate('click');
+      });
+      component.update();
+
+      act(() => {
+        find(`${phase}-downsampleFixedIntervalUnits.filter-option-${units}`).simulate('click');
+      });
+      component.update();
+    }
+  };
+
+export const createDownsampleActions = (testBed: TestBed, phase: Phase) => {
+  const { exists } = testBed;
+  return {
+    downsample: {
+      exists: () => exists(`${phase}-downsampleSwitch`),
+      toggle: createFormToggleAction(testBed, `${phase}-downsampleSwitch`),
+      setDownsampleInterval: createSetDownsampleIntervalAction(testBed, phase),
+    },
+  };
+};

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/index.ts

@@ -21,6 +21,7 @@ export { createForceMergeActions } from './forcemerge_actions';
 export { createReadonlyActions } from './readonly_actions';
 export { createIndexPriorityActions } from './index_priority_actions';
 export { createShrinkActions } from './shrink_actions';
+export { createDownsampleActions } from './downsample_actions';
 export {
   createHotPhaseActions,
   createWarmPhaseActions,

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/phases.ts

@@ -16,6 +16,7 @@ import {
   createNodeAllocationActions,
   createReplicasAction,
   createSnapshotPolicyActions,
+  createDownsampleActions,
 } from '.';
 
 export const createHotPhaseActions = (testBed: TestBed) => {
@@ -26,6 +27,7 @@ export const createHotPhaseActions = (testBed: TestBed) => {
       ...createReadonlyActions(testBed, 'hot'),
       ...createIndexPriorityActions(testBed, 'hot'),
       ...createSearchableSnapshotActions(testBed, 'hot'),
+      ...createDownsampleActions(testBed, 'hot'),
     },
   };
 };
@@ -39,6 +41,7 @@ export const createWarmPhaseActions = (testBed: TestBed) => {
       ...createIndexPriorityActions(testBed, 'warm'),
       ...createNodeAllocationActions(testBed, 'warm'),
       ...createReplicasAction(testBed, 'warm'),
+      ...createDownsampleActions(testBed, 'warm'),
     },
   };
 };
@@ -51,6 +54,7 @@ export const createColdPhaseActions = (testBed: TestBed) => {
       ...createIndexPriorityActions(testBed, 'cold'),
       ...createNodeAllocationActions(testBed, 'cold'),
       ...createSearchableSnapshotActions(testBed, 'cold'),
+      ...createDownsampleActions(testBed, 'cold'),
     },
   };
 };

x-pack/plugins/index_lifecycle_management/common/types/policies.ts

@@ -15,6 +15,8 @@ export type PhaseWithTiming = keyof Omit<Phases, 'hot'>;
 
 export type PhaseExceptDelete = keyof Omit<Phases, 'delete'>;
 
+export type PhaseWithDownsample = 'hot' | 'warm' | 'cold';
+
 export interface SerializedPolicy {
   name: string;
   phases: Phases;
@@ -93,6 +95,7 @@ export interface SerializedHotPhase extends SerializedPhase {
     forcemerge?: ForcemergeAction;
     readonly?: {};
     shrink?: ShrinkAction;
+    downsample?: DownsampleAction;
 
     set_priority?: {
       priority: number | null;
@@ -110,6 +113,7 @@ export interface SerializedWarmPhase extends SerializedPhase {
     shrink?: ShrinkAction;
     forcemerge?: ForcemergeAction;
     readonly?: {};
+    downsample?: DownsampleAction;
     set_priority?: {
       priority: number | null;
     };
@@ -121,6 +125,7 @@ export interface SerializedColdPhase extends SerializedPhase {
   actions: {
     freeze?: {};
     readonly?: {};
+    downsample?: DownsampleAction;
     allocate?: AllocateAction;
     set_priority?: {
       priority: number | null;
@@ -178,6 +183,10 @@ export interface ForcemergeAction {
   index_codec?: 'best_compression';
 }
 
+export interface DownsampleAction {
+  fixed_interval: string;
+}
+
 export interface LegacyPolicy {
   name: string;
   phases: {

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx

@@ -15,6 +15,7 @@ import {
   IndexPriorityField,
   ReplicasField,
   ReadonlyField,
+  DownsampleField,
 } from '../shared_fields';
 
 import { Phase } from '../phase';
@@ -38,6 +39,8 @@ export const ColdPhase: FunctionComponent = () => {
       {/* Readonly section */}
       {!isUsingSearchableSnapshotInHotPhase && <ReadonlyField phase="cold" />}
 
+      {!isUsingSearchableSnapshotInHotPhase && <DownsampleField phase="cold" />}
+
       {/* Data tier allocation section */}
       <DataTierAllocationField
         description={i18nTexts.dataTierAllocation.description}

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

@@ -29,6 +29,7 @@ import {
   SearchableSnapshotField,
   ReadonlyField,
   ShrinkField,
+  DownsampleField,
 } from '../shared_fields';
 import { Phase } from '../phase';
 
@@ -176,6 +177,7 @@ export const HotPhase: FunctionComponent = () => {
           <ShrinkField phase={'hot'} />
           {license.canUseSearchableSnapshot() && <SearchableSnapshotField phase="hot" />}
           <ReadonlyField phase={'hot'} />
+          <DownsampleField phase="hot" />
         </>
       )}
       <IndexPriorityField phase={'hot'} />