Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get mb field name #131766

Closed
wants to merge 2 commits into from
Closed

Get mb field name #131766

wants to merge 2 commits into from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 6, 2022

Part of #116150

#114553 migrated from using mvt's generated by the Kibana server to mvt's generated by Elasticsearch. During this migration, some tech debt was added in order to have this feature make 8.0 FF. These need to be cleaned up in 8.1.

Remove getMbFieldName from IDynamicStyleProperty interface. DynamicStyleProperty already has a method, getMbPropertyName, for this purpose. getMbPropertyName should be used anywhere getMbFieldName was added.

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 6, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 6, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette custom color palette should return mapbox expression for custom color palette
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette custom color palette should return null when customColorPalette is empty
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette custom color palette should return null when customColorPalette is not provided
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette pre-defined color palette should return mapbox expression for color palette
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette pre-defined color palette should return null when color palette is not provided
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette should return null when field is not provided
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) categorical color palette should return null when field name is not provided
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp custom color ramp should return null when customColorRamp is empty
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp custom color ramp should return null when customColorRamp is not provided
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp custom color ramp should use feature-state for geojson source
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp interpolate color ramp should return null when color ramp is not provided
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp should return null when field is not provided
  • [job] [logs] Jest Tests #3 / get mapbox color expression (via internal _getMbColor) ordinal color ramp should return null when field name is not provided
  • [job] [logs] Jest Tests #3 / get mapbox icon-image expression (via internal _getMbIconImageExpression) categorical icon palette should return mapbox expression for custom icon palette
  • [job] [logs] Jest Tests #3 / get mapbox icon-image expression (via internal _getMbIconImageExpression) categorical icon palette should return mapbox expression for pre-defined icon palette
  • [job] [logs] Jest Tests #3 / syncSize Should sync with circle-radius prop

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB -15.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Maps release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants