Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] clean-up ES mvt migration tech debt #116150

Closed
2 of 5 tasks
nreese opened this issue Oct 25, 2021 · 3 comments
Closed
2 of 5 tasks

[maps] clean-up ES mvt migration tech debt #116150

nreese opened this issue Oct 25, 2021 · 3 comments
Labels
chore Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@nreese
Copy link
Contributor

nreese commented Oct 25, 2021

#114553 migrated from using mvt's generated by the Kibana server to mvt's generated by Elasticsearch. During this migration, some tech debt was added in order to have this feature make 8.0 FF. These need to be cleaned up in 8.1.

  • Remove getMbFieldName from IDynamicStyleProperty interface. DynamicStyleProperty already has a method, getMbPropertyName, for this purpose. getMbPropertyName should be used anywhere getMbFieldName was added.
  • Move elasticsearch_util folder from common to public. elasticsearch_util folder was moved to common when Kibana server mvt were originally implemented. Now that elasticsearch_util folder is never used in server, the folder should be moved back to public.
  • Refactor classes/layer folder structure. Move all implementations of IVectorLayer into vector_layer folder. This includes moving contents of blended_vector_layer and tiled_vector_layer folder into vector_layer folder. Rename TiledVectorLayer to MvtVectorLayer and rename VectorLayer to GeojsonVectorLayer. [Maps] rename VectorLayer to GeoJsonVectorLayer and TiledVectorLayer to MvtVectorLayer #117207
  • Move Elasticsearch specific MVT implementation logic from TiledVectorLayer into a new class called EsMvtVectorLayer.
  • [ ] enable gzipping (this is not supported by the v8 ES-JS client) tracked with [Maps] gzip mvt tiles #121822
  • consolidate textLayer and labelLayer into single layer [Maps] use single layer for map labels #116840
@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation technical debt Improvement of the software architecture and operational architecture v8.1.0 labels Oct 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@jb1b84 jb1b84 added Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Feb 23, 2023

Closing, most items completed and no longer tracking this effort

@nreese nreese closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants