Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix inconsistent usage of arrow icons on Surrounding documents page #129292

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[Discover] Fix inconsistent usage of arrow icons on Surrounding documents page #129292

merged 1 commit into from
Apr 4, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 4, 2022

Closes #122576

Summary

The decision was to remove arrow icons (which were next to Load buttons) from Surrounding documents page to fix inconsistency in their usage across Discover pages.

Screenshot 2022-04-04 at 10 11 12

@jughosta jughosta added Feature:Discover Discover Application release_note:fix backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0 labels Apr 4, 2022
@jughosta jughosta requested a review from a team as a code owner April 4, 2022 08:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested locally using Safari, Firefox, Chrome, MacOS, Works as expected. Congrats for fixing the first fix-it-week issue! 🏅

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 400.4KB 400.3KB -33.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jughosta jughosta merged commit d9153a6 into elastic:main Apr 4, 2022
@jughosta jughosta deleted the 122576-fix-inconsistent-icons branch April 4, 2022 10:03
@jughosta jughosta self-assigned this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting :DataDiscovery/fix-it-week Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[discover] inconsistent usage of arrow icons
4 participants
@jughosta @elasticmachine @kibana-ci @kertal