Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discover] inconsistent usage of arrow icons #122576

Closed
nreese opened this issue Jan 10, 2022 · 4 comments · Fixed by #129292
Closed

[discover] inconsistent usage of arrow icons #122576

nreese opened this issue Jan 10, 2022 · 4 comments · Fixed by #129292
Assignees
@jughosta
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week discuss Feature:Discover Discover Application good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@nreese
Copy link
Contributor

nreese commented Jan 10, 2022 •
edited
Loading

Notice in the screen shot below from Discover page how arrowRight and arrowDown icons are used to collapse/expand. Then notice in the "view surrounding documents" screen shot. The arrowDown icon is not used to collapse/expand and is just part of the button to fetch more surrounding documents. I clicked on this icon expecting to collapse the surrounding documents older than this document. To avoid the confusion, I recommend removing the arrowUp and arrowDown icons on the "view surrounding documents" page since they do not really provide any value and are misleading/inconsistent with how the icon is used elsewhere in Discover.

Screen Shot 2022-01-10 at 1 30 40 PM

Screen Shot 2022-01-10 at 1 33 28 PM
@nreese nreese added bug Fixes for quality problems that affect the customer experience discuss Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@nreese nreese added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 10, 2022
@kertal
Copy link
Member

kertal commented Jan 17, 2022

I'm fine removing the arrows of surrounding documents Load button for better consistency, wdyt @andreadelrio

@andreadelrio
Copy link
Contributor

I'm fine removing the arrows of surrounding documents Load button for better consistency, wdyt @andreadelrio

@kertal sounds good to me as well!

@kertal kertal added the good first issue low hanging fruit label Mar 24, 2022
@jughosta jughosta self-assigned this Apr 4, 2022
@jughosta jughosta mentioned this issue Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week discuss Feature:Discover Discover Application good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Fix inconsistent usage of arrow icons on Surrounding documents page jughosta/kibana
5 participants
@nreese @kertal @jughosta @andreadelrio @elasticmachine