[APM] Adding db statement to simple trace sample #129217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:skip
|
@elasticmachine merge upstream |
boriskirov
reviewed
Apr 4, 2022
|
@elasticmachine merge upstream |
dgieselaar
reviewed
Apr 6, 2022
packages/elastic-apm-synthtrace/src/scripts/examples/01_simple_trace.ts
Outdated
Show resolved
Hide resolved
dgieselaar
reviewed
Apr 7, 2022
dgieselaar
reviewed
Apr 7, 2022
dgieselaar
reviewed
Apr 10, 2022
| instance | ||
| .span('GET apm-*/_search', 'db', 'elasticsearch') | ||
| .defaults({ 'span.db.statement': JSON.stringify(mockDbStatement) }) |
There was a problem hiding this comment.
I think the format for ES requests is slightly different. Do you mind having a look at opbeans data and creating a function that formats it in the way the agent does? I think it's something like query parameters url encoded on the first line, then the actual request body on the second line.
dgieselaar
reviewed
Apr 10, 2022
| .defaults({ 'span.db.statement': 'SELECT * FROM PRODUCTS' }) | ||
| .duration(1000) | ||
| .success() | ||
| .destination('elasticsearch') |
There was a problem hiding this comment.
why does a SQL span talk to ES?
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
auto-merge was automatically disabled
May 9, 2022 13:12
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #129193
This PR adds a long
db statementso we can test the UI.