Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Convert DB statement code box to EuiCode #129193

Merged
merged 6 commits into from
Apr 4, 2022
Merged

[APM] Convert DB statement code box to EuiCode #129193

merged 6 commits into from
Apr 4, 2022

Conversation

boriskirov
Copy link
Contributor

@boriskirov boriskirov commented Apr 1, 2022 •
edited
Loading

Closes #76849
Closes #127063

Summary

Two small UI improvements in the Span Flyout:

image

  1. The database statement as part of the highlighted data pieces in the Span flyout is now using our EuiCode component with highlighting. Related to that issue.

image

  1. Order improvement of the search and link for custom labels. The order is swapped for better UI balance and usability.

image

@boriskirov boriskirov added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Apr 1, 2022
@boriskirov boriskirov marked this pull request as ready for review April 1, 2022 12:28
@boriskirov boriskirov requested a review from a team as a code owner April 1, 2022 12:28
@boriskirov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

cauemarcondes
cauemarcondes requested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up 🧹. I added a few nit items.

x-pack/plugins/apm/public/components/shared/metadata_table/index.tsx Show resolved Hide resolved
...saction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/span_db.tsx Show resolved Hide resolved
...saction_details/waterfall_with_summary/waterfall_container/waterfall/span_flyout/span_db.tsx Show resolved Hide resolved
@boriskirov boriskirov requested a review from cauemarcondes April 1, 2022 15:53
@cauemarcondes cauemarcondes mentioned this pull request Apr 1, 2022
Closed
cauemarcondes
cauemarcondes approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 nice work 👏🏻

@boriskirov
Copy link
Contributor Author

@elasticmachine merge upstream

@boriskirov boriskirov enabled auto-merge (squash) April 4, 2022 11:49
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #12 / alerting api integration spaces only Alerting builtin alertTypes es_query alert runs correctly: use epoch millis - threshold on hit count < > for searchSource search type

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1186 1184 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB -1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@boriskirov boriskirov merged commit 881a8ec into elastic:main Apr 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 4, 2022
@boriskirov boriskirov mentioned this pull request Jun 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist left review comments

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Elasticsearch query does't break line on span flyout [APM] Convert DB statement code box to EuiCode
6 participants
@boriskirov @kibanamachine @elasticmachine @kibana-ci @formgeist @cauemarcondes