Add type murmur3 into the lens fields list #129029

ebuildy · 2022-03-31T10:17:53Z

Summary

Related to issue #129007 (Fields of type murmur3 dont appear in the lens fields list).

This PR add field of type murmur3 in the fields listing for lens visualization.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

Risk Matrix

For maintainers

This was checked for breaking API changes and was labeled appropriately

To fix #129007 , naive approach.

kibanamachine · 2022-03-31T10:17:55Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

flash1293 · 2022-03-31T10:48:44Z

This is super unlucky timing, but 8.3 just got branched off and there's no snapshot builds yet for the elasticsearch plugins https://artifacts-api.elastic.co/v1/search/8.3.0-SNAPSHOT

They should become available soon, I will check daily and once they are built I will give it a test-run to see whether something breaks unexpectedly.

ebuildy · 2022-03-31T19:10:52Z

it works like a charm! I have just understood the "operation" idea behind Lens, really clever!

So, I have only enabled murmur3 for cardinality operations.

flash1293 · 2022-04-01T13:38:59Z

@elasticmachine merge upstream

flash1293 · 2022-04-01T13:59:23Z

This looks pretty good already! Some rough edges I noticed:

"Top values" don't really make any sense for murmur3 - we should opt out of fetching a field summary for this field type like we do for ranges:

kibana/x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx

Line 463 in 41da240

} else if (field.type.includes('range')) {

The file icon is not exactly pretty, but I'm not sure which one to use, maybe tokenSearchType - @MichaelMarcialis do you have a suggestion? We would need to adjust it here:

kibana/packages/kbn-react-field/src/field_icon/field_icon.tsx

Line 49 in 2f46899

murmur3: { iconType: 'tokenFile' },

Please do not add translations, there's a separate process for that, it will be handled outside of this PR.

ebuildy · 2022-04-04T09:00:15Z

We are using this fix on prod for 3 days now (we are using kibana v7.17.1), very happy with it!

I will squash commits when this is ready for review, thanks you.

flash1293 · 2022-04-04T11:04:17Z

@elasticmachine merge upstream

flash1293 · 2022-04-04T11:04:40Z

Buildkite, test this

elasticmachine · 2022-04-04T11:04:59Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

…-fix'

MichaelMarcialis · 2022-04-04T14:26:09Z

The file icon is not exactly pretty, but I'm not sure which one to use, maybe tokenSearchType - @MichaelMarcialis do you have a suggestion?

Given what we have available in our EUI tokens, I agree that tokenSearchType appears to be the best fit.

flash1293 · 2022-04-04T16:34:55Z

@ebuildy Could you adapt the icon for murmur3 in here?

kibana/packages/kbn-react-field/src/field_icon/field_icon.tsx

Line 49 in 2f46899

murmur3: { iconType: 'tokenFile' },

Also there seems to be a small issue with the linting.

Apart from that I think we can get this PR ready to merge, thank you so much for your contribution 💚

I will squash commits when this is ready for review, thanks you.

No need to do that, Github will take care of it on merge.

ebuildy · 2022-04-04T19:14:53Z

lint issue seem have been fixed / committed automatically

flash1293 · 2022-04-05T09:30:12Z

@elasticmachine merge upstream

flash1293 · 2022-04-05T10:08:47Z

x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx

@@ -460,7 +460,7 @@ function FieldItemPopoverContents(props: State & FieldItemProps) {

  if (props.isLoading) {
    return <EuiLoadingSpinner />;
-  } else if (field.type.includes('range')) {
+  } else if (field.type.includes('range') || field.type === 'murmur3') {
    return (
      <>
        <EuiPopoverTitle>{panelHeader}</EuiPopoverTitle>


The message specifically calls out "range type fields" which doesn't match the murmur3 case. Could you add a separate branch for this case with a new i18n phrase Summary information is not available for murmur3 fields?

Just went ahead and pushed this change

flash1293 · 2022-04-05T10:09:07Z

One last thing I noticed, otherwise this looks great! #129029 (comment)

flash1293 · 2022-04-07T14:12:13Z

Buildkite, test this.

flash1293 · 2022-04-12T10:54:24Z

@elasticmachine merge upstream

flash1293 · 2022-04-12T10:54:29Z

Buildkite, test this

flash1293 · 2022-04-12T13:00:36Z

@elasticmachine run elasticsearch-ci/docs

flash1293 · 2022-04-12T13:14:43Z

@elasticmachine merge upstream

flash1293 · 2022-04-12T13:16:53Z

Buildkite, test this

flash1293 · 2022-04-12T13:38:27Z

@elasticmachine run elasticsearch-ci/docs

kibana-ci · 2022-04-12T14:44:43Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataVisualizer`	539.6KB	539.6KB	+6.0B
`discover`	407.0KB	407.0KB	+12.0B
`graph`	476.8KB	476.8KB	+6.0B
`lens`	1.0MB	1.0MB	+403.0B
`maps`	2.7MB	2.7MB	+6.0B
`presentationUtil`	136.8KB	136.8KB	+6.0B
`securitySolution`	4.8MB	4.8MB	+6.0B
`stackAlerts`	202.8KB	202.8KB	+6.0B
total			+451.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`osquery`	16.2KB	16.2KB	+6.0B

History

💛 Build #37551 was flaky ae91968
💔 Build #36850 failed 8f4c886
💔 Build #35831 failed 4d1de8d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @flash1293

flash1293 · 2022-04-12T16:03:09Z

Apologies for taking this over a bit @ebuildy . Merging now as this looks fine, thanks for your contribution 💚

ebuildy · 2022-04-12T19:12:43Z

@flash1293 I see kibana is a really big project ^^ no worries, I am very happy about this feature.

ebuildy added 2 commits March 31, 2022 09:05

Add murmur3 type to fields list

f650956

To fix #129007 , naive approach.

Add murmur3 type to fields list

67beea5

ebuildy requested a review from a team as a code owner March 31, 2022 10:17

kibanamachine added the 💝community label Mar 31, 2022

flash1293 self-assigned this Mar 31, 2022

Add murmur3 type to fields list

4caa70f

Merge branch 'main' into patch-1

0a79f6e

ebuildy added 3 commits April 4, 2022 10:49

removed translations

67af6c7

Merge branch 'patch-1' of github.com:ebuildy/kibana into patch-1

18e91c0

disable field preview

6c2ed98

Merge branch 'main' into patch-1

4d1de8d

flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.3.0 labels Apr 4, 2022

flash1293 added release_note:enhancement and removed enhancement New value added to drive a business result labels Apr 4, 2022

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

aa2fd60

…-fix'

ebuildy added 2 commits April 4, 2022 20:35

change icon

4b58340

Merge branch 'patch-1' of github.com:ebuildy/kibana into patch-1

cfcfefe

ebuildy requested a review from a team as a code owner April 4, 2022 19:14

Merge branch 'main' into patch-1

ffa23c7

flash1293 reviewed Apr 5, 2022

View reviewed changes

flash1293 added 2 commits April 7, 2022 16:04

Merge remote-tracking branch 'upstream/main' into patch-1

cbe3e24

add specific murmur3 message

8f4c886

fix test

ae91968

flash1293 changed the title ~~[draft] Add type murmur3 into the lens fields list~~ Add type murmur3 into the lens fields list Apr 7, 2022

Merge branch 'main' into patch-1

2ffb885

vadimkibana approved these changes Apr 12, 2022

View reviewed changes

flash1293 approved these changes Apr 12, 2022

View reviewed changes

Merge branch 'main' into patch-1

1f95448

flash1293 merged commit 062be57 into elastic:main Apr 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add type murmur3 into the lens fields list #129029

Add type murmur3 into the lens fields list #129029

ebuildy commented Mar 31, 2022 •

edited

Loading

kibanamachine commented Mar 31, 2022

flash1293 commented Mar 31, 2022

ebuildy commented Mar 31, 2022 •

edited

Loading

flash1293 commented Apr 1, 2022

flash1293 commented Apr 1, 2022 •

edited

Loading

ebuildy commented Apr 4, 2022

flash1293 commented Apr 4, 2022

flash1293 commented Apr 4, 2022

elasticmachine commented Apr 4, 2022

MichaelMarcialis commented Apr 4, 2022

flash1293 commented Apr 4, 2022

ebuildy commented Apr 4, 2022

flash1293 commented Apr 5, 2022

flash1293 Apr 5, 2022

flash1293 Apr 7, 2022

flash1293 commented Apr 5, 2022

flash1293 commented Apr 7, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

kibana-ci commented Apr 12, 2022

flash1293 commented Apr 12, 2022

ebuildy commented Apr 12, 2022

Add type murmur3 into the lens fields list #129029

Add type murmur3 into the lens fields list #129029

Conversation

ebuildy commented Mar 31, 2022 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

kibanamachine commented Mar 31, 2022

flash1293 commented Mar 31, 2022

ebuildy commented Mar 31, 2022 • edited Loading

flash1293 commented Apr 1, 2022

flash1293 commented Apr 1, 2022 • edited Loading

ebuildy commented Apr 4, 2022

flash1293 commented Apr 4, 2022

flash1293 commented Apr 4, 2022

elasticmachine commented Apr 4, 2022

MichaelMarcialis commented Apr 4, 2022

flash1293 commented Apr 4, 2022

ebuildy commented Apr 4, 2022

flash1293 commented Apr 5, 2022

flash1293 Apr 5, 2022

Choose a reason for hiding this comment

flash1293 Apr 7, 2022

Choose a reason for hiding this comment

flash1293 commented Apr 5, 2022

flash1293 commented Apr 7, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

flash1293 commented Apr 12, 2022

kibana-ci commented Apr 12, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

flash1293 commented Apr 12, 2022

ebuildy commented Apr 12, 2022

ebuildy commented Mar 31, 2022 •

edited

Loading

ebuildy commented Mar 31, 2022 •

edited

Loading

flash1293 commented Apr 1, 2022 •

edited

Loading