Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields of type murmur3 dont appear in the lens fields list #129007

Closed
ebuildy opened this issue Mar 31, 2022 · 4 comments
Closed

Fields of type murmur3 dont appear in the lens fields list #129007

ebuildy opened this issue Mar 31, 2022 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ebuildy
Copy link
Contributor

ebuildy commented Mar 31, 2022

Kibana version: 7.17.1

Elasticsearch version: 7.17.1 , with murmur3 plugin

Original install method (e.g. download page, yum, from source, etc.): Docker

Describe the bug:

Field with type murmur3 dont show up on Lens fields list. According here, https://github.com/elastic/kibana/blob/v8.1.1/x-pack/plugins/lens/public/indexpattern_datasource/datapanel.tsx#L70, the list seems hardcoded?

Steps to reproduce:

  1. With plugin murmur3 installed, create elasticsearch index with following mapping:
token: {
  type: "keyword",
  fields: {
    hash: {
       type: "murmur3"
    }
  }
}
  1. Create the kibana index pattern, the "token.hash" field is here
  2. Go to Lens editor, field "token.hash" is missing

BTW the field appear on legacy aggregation visualization.

Expected behavior:

On Lens editor, field of type murmur3 should be present in the fields listing.

@ebuildy ebuildy added the bug Fixes for quality problems that affect the customer experience label Mar 31, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 31, 2022
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 31, 2022
@flash1293 flash1293 added enhancement New value added to drive a business result needs-team Issues missing a team label and removed bug Fixes for quality problems that affect the customer experience labels Mar 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 31, 2022
@flash1293
Copy link
Contributor

You are correct, the shown field types in Lens are hardcoded and murmur3 is not part of them. Thanks for bringing up this use case, I will raise it with the team.

@ebuildy
Copy link
Contributor Author

ebuildy commented Mar 31, 2022

I am doing this PR, seems ok: main...ebuildy:patch-1 (not tested yet)

@flash1293
Copy link
Contributor

@ebuildy Awesome, thanks for that! If you open a PR against elastic/kibana I can check it out. I guess one problem will be that there's no icon for it, but I'm sure we will find a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants