[Security Solution] Rule Preview Table Follow-up #128981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumlee
added
release_note:skip
dplumlee
force-pushed
the
rule-preview-follow-up
branch
3 times, most recently
from
bbb7c16 to
be583b0
Compare
dplumlee
commented
Apr 6, 2022
| @@ -6,7 +6,7 @@ | |||
| */ | |||
|
|
|||
| export enum RULE_PREVIEW_INVOCATION_COUNT { | |||
| HOUR = 20, | |||
| HOUR = 12, | |||
There was a problem hiding this comment.
Someone (me) couldn't do basic math it seems 😢
dplumlee
force-pushed
the
rule-preview-follow-up
branch
2 times, most recently
from
4263fab to
fb68d73
Compare
dplumlee
added
the
bug
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
dplumlee
force-pushed
the
rule-preview-follow-up
branch
from
d3a2dcb to
ea6902d
Compare
| dataProviders, | ||
| defaultColumns, | ||
| deletedEventIds, | ||
| graphEventId, // If truthy, the graph viewer (Resolver) is showing |
There was a problem hiding this comment.
probably don't need this, and if you do, https://github.com/elastic/kibana/blob/main/x-pack/plugins/timelines/public/components/t_grid/integrated/index.tsx#L116 should be graphEventId?: string; instead
kqualters-elastic
approved these changes
Apr 11, 2022
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @dplumlee |
dplumlee
added
the
auto-backport
kibanamachine
pushed a commit
that referenced
this pull request
Apr 11, 2022
(cherry picked from commit 268470a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previous PR: #127986
Fixes some known bugs in the previous rule preview table PR including:
stackByfield #129664)Preview resultslimit not respected forLast hour#129025)Preview resultsaction can be performed without entering any custom query #129031)Preview resultsalert table with theEven rendered view#129037) - might add back if theres timekibana.alert.original_time)Checklist
Delete any items that are not applicable to this PR.
For maintainers