Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Rule name button link #128850

Merged
merged 3 commits into from
Apr 12, 2022
Merged

[Security Solution] Rule name button link #128850

merged 3 commits into from
Apr 12, 2022

Conversation

kqualters-elastic
Copy link
Contributor

@kqualters-elastic kqualters-elastic commented Mar 30, 2022 •
edited
Loading

Summary

This pr makes it so that the rule detail "link" in the hover actions for timelines and event tables is now an a tag, to allow for right/shift clicking and better affordance with something that takes a user to another page.
Result:
image
A lot of this code could be refactored to be a little less repetitive, each of the fields that links via an a tag has it's own very similar component for example, but to fix the bug for one of the more popular a tags in the security solution this pr just follows the existing paradigm.
Resolves: #124306

Checklist

@kqualters-elastic kqualters-elastic added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Investigations Security Solution Investigations Team v8.2.0 labels Apr 12, 2022
@kqualters-elastic kqualters-elastic marked this pull request as ready for review April 12, 2022 14:52
@kqualters-elastic kqualters-elastic requested a review from a team as a code owner April 12, 2022 14:52
michaelolo24
michaelolo24 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kqualters-elastic kqualters-elastic enabled auto-merge (squash) April 12, 2022 15:05
@kqualters-elastic kqualters-elastic merged commit b7dc8f0 into elastic:main Apr 12, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +522.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Apr 12, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 12, 2022
@kqualters-elastic
Use a link to enable shift/right click of rule names in the popover (#…
b75dc0d 
…128850)

(cherry picked from commit b7dc8f0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 12, 2022
@kibanamachine @kqualters-elastic
Use a link to enable shift/right click of rule names in the popover (#…
2b45f55 
…128850) (#130038)

(cherry picked from commit b7dc8f0)

Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
@kqualters-elastic kqualters-elastic deleted the rule-name-button-link branch June 2, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmonschke janmonschke janmonschke approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution][Detections] Within Alerts Table cannot open Rule Details link in a new tab
5 participants
@kqualters-elastic @kibana-ci @kibanamachine @janmonschke @michaelolo24