Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] Removing usage of deprecated apis #127883

Merged
merged 5 commits into from
Mar 18, 2022
Merged

[Response Ops] Removing usage of deprecated apis #127883

merged 5 commits into from
Mar 18, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Mar 16, 2022 •
edited
Loading

Resolves #126961

Summary

Updates usages of deprecated types and functions.

@ymao1 ymao1 changed the title Removing usage of deprecated apis [Response Ops] Removing usage of deprecated apis Mar 16, 2022
@ymao1 ymao1 self-assigned this Mar 16, 2022
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0 labels Mar 16, 2022
@ymao1 ymao1 marked this pull request as ready for review March 16, 2022 20:06
@ymao1 ymao1 requested review from a team as code owners March 16, 2022 20:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

nickpeihl
nickpeihl approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review

mikecote
mikecote approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@ymao1 ymao1 enabled auto-merge (squash) March 18, 2022 01:09
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackAlerts 55 111 +56

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 166.8KB 193.9KB +27.1KB
Unknown metric groups

References to deprecated APIs

id before after diff
actions 12 7 -5
alerting 17 5 -12
stackAlerts 183 6 -177
total -194

Unreferenced deprecated APIs

id before after diff
data 55 56 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit bb3aac0 into elastic:main Mar 18, 2022
@ymao1 ymao1 deleted the alerting/remove-deprecated-apis branch March 18, 2022 02:25
This was referenced May 5, 2022
Closed
Closed
@mikecote mikecote mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@mikecote mikecote mikecote approved these changes

Assignees

@ymao1 ymao1

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps - E&C] Remove references to deprecated APIs due for removal in 8.2
5 participants
@ymao1 @elasticmachine @kibana-ci @nickpeihl @mikecote