Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack rules] Removal of IFieldType type #124122

Closed
mikecote opened this issue Jan 31, 2022 · 1 comment
Closed

[Stack rules] Removal of IFieldType type #124122

mikecote opened this issue Jan 31, 2022 · 1 comment
Labels
chore Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

See #107235.

The IFieldType type is too ambiguous - either IndexPatternField or IndexPatternFieldBase should be used instead. You probably want IndexPatternField - its the class representation of a field. IndexPatternFieldBase is a simplified static version that primarily exists to be passed into a query.

Please feel free to reach out to @elastic/kibana-app-services if there's any difficulty in making this change.
@mikecote mikecote added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types labels Jan 31, 2022
@mikecote mikecote mentioned this issue Jan 31, 2022
Closed
3 tasks
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@mikecote mikecote added the chore label May 3, 2022
@mikecote
Copy link
Contributor Author

mikecote commented May 5, 2022

Done as part of #127883

@mikecote mikecote closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kobelb @mikecote