Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index patterns] Removal of IFieldType type #107235

Closed
3 tasks done
mattkime opened this issue Jul 29, 2021 · 2 comments
Closed
3 tasks done

[index patterns] Removal of IFieldType type #107235

mattkime opened this issue Jul 29, 2021 · 2 comments
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) technical debt Improvement of the software architecture and operational architecture

Comments

@mattkime
Copy link
Contributor

mattkime commented Jul 29, 2021 •
edited by kertal
Loading

The IFieldType type is too ambiguous - either IndexPatternField or IndexPatternFieldBase should be used instead. You probably want IndexPatternField - its the class representation of a field. IndexPatternFieldBase is a simplified static version that primarily exists to be passed into a query.

Please feel free to reach out to @elastic/kibana-app-services if there's any difficulty in making this change.

@elastic/kibana-app-services

  • src/plugins/data - do after all other instances are addressed

@elastic/response-ops

@elastic/infra-monitoring-ui
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 29, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 30, 2021
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 needs-team Issues missing a team label labels Jul 30, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 30, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 2, 2021
@weltenwort weltenwort mentioned this issue Aug 9, 2021
Closed
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 10, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Dec 21, 2021
@mikecote mikecote mentioned this issue Jan 31, 2022
Closed
@smith smith mentioned this issue Jan 31, 2022
Closed
@mattkime mattkime mentioned this issue Apr 5, 2022
Closed
1 task
@petrklapka petrklapka added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:AppServicesSv labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the technical debt Improvement of the software architecture and operational architecture label Jun 7, 2023
@kertal kertal mentioned this issue Jun 7, 2023
Closed
@kertal
Copy link
Member

kertal commented Sep 9, 2024

I've checked our code, and couldn't find any more IFieldType, closing therefore

@kertal kertal closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattkime @kertal @elasticmachine @petrklapka