-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] Remove deprecated include_type_name parameter from es_archiver #122962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
release_note:skip
Skip the PR/issue when compiling release notes
v7.17.0
labels
Jan 13, 2022
Pinging @elastic/kibana-core (Team:Core) |
9 tasks
mshustov
changed the title
[7.17] No include type name
[7.17] Remove deprecated include_type_name parameter from es_archiver
Jan 13, 2022
9 tasks
…include_type_name
rudolf
approved these changes
Jan 14, 2022
afharo
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…include_type_name
tylersmalley
approved these changes
Jan 14, 2022
spalger
approved these changes
Jan 14, 2022
@elasticmachine merge upstream |
Tests fail when running against ES 8.0
These tests fail against ES 8.0
* update downloaded csv snapshots * update csv file length * update more snapshots * update more snapshots * update more snapshots
Removes type from `es.update`
…include_type_name
This reverts commit b756a53.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.17.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #122627 Kibana must be compatible with ES 8.x. Ops team added a CI check to verify the compatibility on CI.
Obviously, some functional tests using deprecated API (removed in 8.x) started failing. This PR makes necessary changes to ensure tests compatibility with the 8.x ES version.
Remove deprecated
include_type_name
param of index and update tests accordinglycloses #122850
closes #122829