Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Remove deprecated include_type_name parameter from es_archiver #122962

Merged
merged 38 commits into from
Jan 15, 2022

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Jan 13, 2022

Summary

After #122627 Kibana must be compatible with ES 8.x. Ops team added a CI check to verify the compatibility on CI.
Obviously, some functional tests using deprecated API (removed in 8.x) started failing. This PR makes necessary changes to ensure tests compatibility with the 8.x ES version.

Remove deprecated include_type_name param of index and update tests accordingly

closes #122850
closes #122829

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v7.17.0 labels Jan 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov mshustov changed the title [7.17] No include type name [7.17] Remove deprecated include_type_name parameter from es_archiver Jan 13, 2022
@mshustov mshustov requested a review from a team January 14, 2022 13:33
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshustov
Copy link
Contributor Author

@elasticmachine merge upstream

@mshustov mshustov enabled auto-merge (squash) January 14, 2022 17:34
Tests fail when running against ES 8.0
TinaHeiligers and others added 6 commits January 14, 2022 13:15
These tests fail against ES 8.0
* update downloaded csv snapshots

* update csv file length

* update more snapshots

* update more snapshots

* update more snapshots
Removes type from `es.update`
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 02b30db into 7.17 Jan 15, 2022
@mshustov mshustov deleted the no-include_type_name branch January 15, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.17.0
Projects
None yet