Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] remove deprecated include_type_name parameter #122929

Closed

Conversation

mshustov
Copy link
Contributor

Summary

Fix them all

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.17.0 labels Jan 13, 2022
@mshustov mshustov changed the title remove deprecated include_type_name parameter [7.17] remove deprecated include_type_name parameter Jan 13, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 13, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Default CI Group #18 / apis SecuritySolution Endpoints Kpi Hosts With auditbeat "before all" hook for "Make sure that we get KpiHosts data"
  • [job] [logs] Default CI Group #18 / apis SecuritySolution Endpoints Kpi Hosts With auditbeat "before all" hook for "Make sure that we get KpiHosts data"
  • [job] [logs] Default CI Group #19 / dashboard feature controls dashboard feature controls security "before all" hook in "dashboard feature controls security"
  • [job] [logs] Default CI Group #19 / dashboard feature controls dashboard feature controls security "before all" hook in "dashboard feature controls security"
  • [job] [logs] Jest Tests #4 / esArchiver: createCreateIndexStream() defaults creates aliases
  • [job] [logs] Default CI Group #7 / GlobalSearch API GlobalSearch providers SavedObject provider "before all" hook for "can search for index patterns"
  • [job] [logs] Default CI Group #7 / GlobalSearch API GlobalSearch providers SavedObject provider "before all" hook for "can search for index patterns"
  • [job] [logs] Default CI Group #20 / saved objects security and spaces enabled _bulk_create user with no access within the default space "before all" hook for "should return 403 forbidden [isolatedtype/defaultspace-isolatedtype-id]"
  • [job] [logs] Default CI Group #20 / saved objects security and spaces enabled _bulk_create user with no access within the default space "before all" hook for "should return 403 forbidden [isolatedtype/defaultspace-isolatedtype-id]"
  • [job] [logs] Default CI Group #9 / saved objects security only enabled _bulk_create user with no access "before all" hook for "should return 403 forbidden [isolatedtype/defaultspace-isolatedtype-id]"
  • [job] [logs] Default CI Group #9 / saved objects security only enabled _bulk_create user with no access "before all" hook for "should return 403 forbidden [isolatedtype/defaultspace-isolatedtype-id]"
  • [job] [logs] Default CI Group #5 / saved objects spaces only enabled _bulk_create within the default space "before all" hook for "should return 200 success [isolatedtype/space1-isolatedtype-id,isolatedtype/space2-isolatedtype-id,dashboard/new-dashboard-id,sharedtype/new-sharedtype-id,globaltype/new-globaltype-id,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id,sharedtype/new-each-space-id,sharedtype/new-all-spaces-id] and bad request [hiddentype/any,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id] and conflict [isolatedtype/defaultspace-isolatedtype-id,sharedtype/all_spaces,sharedtype/default_and_space_1,sharedtype/only_space_1,sharedtype/only_space_2,sharecapabletype/only_default_space,sharecapabletype/only_space_1,globaltype/globaltype-id]"
  • [job] [logs] Default CI Group #5 / saved objects spaces only enabled _bulk_create within the default space "before all" hook for "should return 200 success [isolatedtype/space1-isolatedtype-id,isolatedtype/space2-isolatedtype-id,dashboard/new-dashboard-id,sharedtype/new-sharedtype-id,globaltype/new-globaltype-id,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id,sharedtype/new-each-space-id,sharedtype/new-all-spaces-id] and bad request [hiddentype/any,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id] and conflict [isolatedtype/defaultspace-isolatedtype-id,sharedtype/all_spaces,sharedtype/default_and_space_1,sharedtype/only_space_1,sharedtype/only_space_2,sharecapabletype/only_default_space,sharecapabletype/only_space_1,globaltype/globaltype-id]"
  • [job] [logs] Default CI Group #14 / saved objects tagging - functional tests table listing "before all" hook in "table listing"
  • [job] [logs] Default CI Group #14 / saved objects tagging - functional tests table listing "before all" hook in "table listing"
  • [job] [logs] Default CI Group #10 / saved objects tagging API - security and spaces integration GET /api/saved_objects_tagging/tags/{id} "before all" hook for "returns expected 200 response for superuser"
  • [job] [logs] Default CI Group #10 / saved objects tagging API - security and spaces integration GET /api/saved_objects_tagging/tags/{id} "before all" hook for "returns expected 200 response for superuser"
  • [job] [logs] Default CI Group #12 / saved objects tagging API DELETE /api/saved_objects_tagging/tags/{id} "before each" hook for "should delete the tag"
  • [job] [logs] Default CI Group #12 / saved objects tagging API DELETE /api/saved_objects_tagging/tags/{id} "before each" hook for "should delete the tag"
  • [job] [logs] Default CI Group #8 / spaces api with security copy to spaces user with no access from the default space single-namespace types "before each" hook for "should return 403 when copying to space without conflicts or references"
  • [job] [logs] Default CI Group #8 / spaces api with security copy to spaces user with no access from the default space single-namespace types "before each" hook for "should return 403 when copying to space without conflicts or references"
  • [job] [logs] Default CI Group #2 / spaces api without security copy to spaces from the default space single-namespace types "before each" hook for "should return 200 when copying to space without conflicts or references"
  • [job] [logs] Default CI Group #2 / spaces api without security copy to spaces from the default space single-namespace types "before each" hook for "should return 200 when copying to space without conflicts or references"
  • [job] [logs] Default CI Group #4 / Spaces app Copy Saved Objects to Space "after all" hook for "allows a dashboard to be copied to the marketing space, with circular references"
  • [job] [logs] Default CI Group #4 / Spaces app Copy Saved Objects to Space "after all" hook for "allows a dashboard to be copied to the marketing space, with circular references"
  • [job] [logs] Default CI Group #4 / Spaces app Copy Saved Objects to Space "before all" hook for "allows a dashboard to be copied to the marketing space, with all references"
  • [job] [logs] Default CI Group #4 / Spaces app Copy Saved Objects to Space "before all" hook for "allows a dashboard to be copied to the marketing space, with all references"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov
Copy link
Contributor Author

superseded by #122962

@mshustov mshustov closed this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants