Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds the 8.0.0-rc1 release notes #120806
[DOCS] Adds the 8.0.0-rc1 release notes #120806
Changes from 3 commits
f696e6d
d9b6ac0
e120347
ab358d6
3266d37
6f8d741
d433a3a
ad3e466
5f0ff09
ba72972
f8b197b
fa84abf
884039c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be "saved objects types" or "saved object types". The latter sounds more correct to me, but I don't know what the rules are 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, instead of that PR, I think we should instead link to this issue, which contains much more context on the change: #107678
The PR has very little info; most of the discussion that would be relevant to users is in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description doesn't really capture everything that has changed (as described in the impact section). Plus I don't see any detail about
/api/fleet/agents
in under "impact." It feels like the "Details" section is too specific and the "Impact" section is incomplete.Maybe someone on the dev team should clarify based on what we want to highlight for users. I don't think I'm the person to make this call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton can you add someone from the Dev team to review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @juliaElastic is probably the best person to comment since they opened #119494.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton hi, is the CHANGELOG generated from somewhere or are you expecting me to suggest how to update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliaElastic I think these entries begin in the changelog, but get edited and formatted by the Kibana writers. You should suggest changes if you think (as I do) that this section needs more work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton @juliaElastic I need to merge these release notes in preparation for the release tomorrow. Please feel free to open a separate PR for any changes you want to make, and let me know if you need any help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton
So to summarize:
Changes in Fleet API for consistency, previous versions are still working, and deprecated.
pkgkey
path parameter:response
orlist
toitems
in response properties:response
toitem
in response properties: