-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds the 8.0.0-rc1 release notes #120806
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
docs/CHANGELOG.asciidoc
Outdated
[%collapsible] | ||
==== | ||
*Details* + | ||
Unknown saved objects types now cause {kib} migrations to fail. For more information, refer to {kibana-pull}118300[#118300]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be "saved objects types" or "saved object types". The latter sounds more correct to me, but I don't know what the rules are 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, instead of that PR, I think we should instead link to this issue, which contains much more context on the change: #107678
The PR has very little info; most of the discussion that would be relevant to users is in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one suggested addition below!
[%collapsible] | ||
==== | ||
*Details* + | ||
To make sure all Fleet API GET resposes return `items`, the following have been updated: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description doesn't really capture everything that has changed (as described in the impact section). Plus I don't see any detail about /api/fleet/agents
in under "impact." It feels like the "Details" section is too specific and the "Impact" section is incomplete.
Maybe someone on the dev team should clarify based on what we want to highlight for users. I don't think I'm the person to make this call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton can you add someone from the Dev team to review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @juliaElastic is probably the best person to comment since they opened #119494.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton hi, is the CHANGELOG generated from somewhere or are you expecting me to suggest how to update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliaElastic I think these entries begin in the changelog, but get edited and formatted by the Kibana writers. You should suggest changes if you think (as I do) that this section needs more work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton @juliaElastic I need to merge these release notes in preparation for the release tomorrow. Please feel free to open a separate PR for any changes you want to make, and let me know if you need any help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton
So to summarize:
Changes in Fleet API for consistency, previous versions are still working, and deprecated.
- Rename hyphens to undescores:
- /api/fleet/enrollment-api-keys
- /api/fleet/agent-status
- /api/fleet/service-tokens
- Change packages endpoint to split
pkgkey
path parameter:
- /epm/packages/{pkgkey} to /epm/packages/{packageName}/{version}
- Rename
response
orlist
toitems
in response properties:
- /api/fleet/enrollment_api_keys
- /api/fleet/agents
- /epm/packages/
- /epm/categories
- /epm/packages/_bulk
- /epm/packages/limited
- POST and DELETE /epm/packages/{packageName}/{version}
- Rename
response
toitem
in response properties:
- GET and PUT /epm/packages/{packageName}/{version}
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
… docs/8.0.0-rc1-rn
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
💚 Build Succeeded
History
To update your PR or re-run it, just comment with: cc @KOTungseth |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* [DOCS] Adds the 8.0.0-rc1 release notes * Additions * Apply suggestions from code review * Update docs/CHANGELOG.asciidoc Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Review comments * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Review comments pt 2 Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Lisa Cawley <lcawley@elastic.co> (cherry picked from commit 5433b56)
* [DOCS] Adds the 8.0.0-rc1 release notes * Additions * Apply suggestions from code review * Update docs/CHANGELOG.asciidoc Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Review comments * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Review comments pt 2 Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Lisa Cawley <lcawley@elastic.co> (cherry picked from commit 5433b56)
Summary
Adds the release notes for 8.0.0-rc1.