[Upgrade Assistant] Move fix deprecation logs into the es_deprecation_logs page #118688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
commented
Nov 16, 2021
| } | ||
| // Depending upon setHasNoDeprecationLogs would create an infinite loop. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [error, isLoading, hasLogs]); |
There was a problem hiding this comment.
This was part of the logic used used for setting the step completion when there was no deprecation logs.
| hasPrivileges, | ||
| privilegesMissing, | ||
| }) => { | ||
| const FixLogsStep: FunctionComponent<Props> = ({ hasPrivileges, privilegesMissing }) => { |
There was a problem hiding this comment.
TODO: We should rename this function to something like FixDeprecationLogs, and the same goes for the file itself
|
|
||
| // Depending upon setIsComplete would create an infinite loop. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [isDeprecationLogIndexingEnabled]); |
There was a problem hiding this comment.
This was part of the logic used used for setting the step completion when there was no deprecation logs.
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
HistoryTo update your PR or re-run it, just comment with: cc @sabarasaba |
sebelga
approved these changes
Nov 16, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes step completion logic and moves
fix_deprecation_logsintoes_deprecations_logsfolder.Tests are expected to fail, but will be addressed in a subsequent PR.