[UA] ES deprecation logs in its own page #118659

sebelga · 2021-11-16T09:53:31Z

The deprecation logs coming from ES have some UX flaws. Many of the deprecation logs (some noted as “Critical”) that we expose in Observability are coming from Kibana itself and the user can’t act on them. There isn’t really anything that they can do to solve those deprecations. Those logs create noise and could be a barrier to the upgrade process.

We want to reduce the visibility of the “use of deprecated API” section in Upgrade assistant (step 4 of the wizard) as we can’t confidently rely on them to help the user fix possible use of deprecated ES APIs.

In this PR we have removed the ES deprecation logs UI from the UA overview and moved it to its own page.

TODO

Cleanup current wizard and remove step 4 ([Upgrade Assistant] Move fix deprecation logs into the es_deprecation_logs page #118688)
Embed into new page (Add new page for the deprecation logs #118722)
Fix tests ([Upgrade Assistant] Fix cits, a11y and functional tests #118778)

Screenshots

…_logs page (#118688) * Remove step completion logic and move fix_deprecation_logs folder to es_deprecation_logs * commit using @elastic.co

debadair

Left a few suggestions.

...upgrade_assistant/public/application/components/overview/fix_issues_step/fix_issues_step.tsx

.../upgrade_assistant/public/application/components/es_deprecation_logs/es_deprecation_logs.tsx

cjcenizal · 2021-11-17T03:11:08Z

👍 👍 👍 I haven't looked at the code, only tested locally. This UX feels so much better to me! The logs are accessible but not presented as blockers. Great work @sebelga and @sabarasaba. Let's wait a bit to ensure stakeholders are onboard with this change before merging.

Co-authored-by: debadair <debadair@elastic.co>

cjcenizal · 2021-11-17T18:15:21Z

@sebelga @sabarasaba We have approval to move forward with this change, so feel free to merge when ready.

elasticmachine · 2021-11-17T23:05:34Z

Pinging @elastic/kibana-stack-management (Team:Stack Management)

sabarasaba

code changes lgtm, tested locally 🚀

sebelga · 2021-11-18T11:14:57Z

Thanks for the review @sabarasaba ! Let's wait for @debadair input and then we'll merge it 👍

debadair

Updated the suggestion, but LGTM either way.

Co-authored-by: debadair <debadair@elastic.co>

…_improvements

sebelga · 2021-11-18T19:24:42Z

Thanks for the review @debadair ! 👍

kibana-ci · 2021-11-18T22:19:44Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`upgradeAssistant`	143	145	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`upgradeAssistant`	137.1KB	138.7KB	+1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	308.2KB	308.2KB	+61.0B
`upgradeAssistant`	18.0KB	18.3KB	+311.0B
total			+372.0B

History

💔 Build #7766 failed fb171d4
💚 Build #7586 succeeded 6b40383
💚 Build #7411 succeeded 1121331
💔 Build #7314 failed cbce38b
💔 Build #7112 failed 384f5f2
💚 Build #7027 succeeded ff79e19

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal · 2021-11-19T16:00:43Z

@sebelga I think we'll need to backport this to the 8.0 branch too.

sebelga · 2021-11-22T14:13:28Z

I think we'll need to backport this to the 8.0 branch too.

Do we need to backport if UA is not enabled in 8.0?

cjcenizal · 2021-11-22T14:48:35Z

@sebelga The only reason I can imagine we will need it is if there’s a security flaw in a common dependency that will require making changes throughout all plugins. In a situation like that, a backport would be painful if plugins are inconsistent between branches. The chance of that seems low so we could probably get away with not backporting it. OTOH the effort of a backport seems low. Do you see a downside to backporting?

sebelga · 2021-11-22T15:48:40Z

#119134 was not a straightforward process so I was wondering why we'd need to backport on a branch where we'll only apply security patches or bug fixes. Security patches seem to be more likely to be done server side so would not affect the changes here on UA. The rest are tests and doc links.

cjcenizal · 2021-11-22T16:22:18Z

Ah, thanks for explaining Seb! I didn't know that you encountered a large number of merge conflicts when you forwardported the change to main. I'll leave it to you to decide what's right. At this point I'm more curious about the cause of those merge conflicts. My guess is we missed some forwardports while #114966 was in flight. For example, it looks like #112907 didn't get forwardported.

sebelga · 2021-11-22T16:25:36Z

With that said I did create the backport as indeed it is little effort and aligned branches are a very good thing to do for our future selves. 😊 (#119345)

The conflicts with the previous backport came mainly because of translation being updated for the 7.16 release. And I think translation go main > 7.16 while we go 7.16 > main. So a change of translation key while working on 7.16 creates conflicts.

…119345)

…stic#119134)

Initial commit

ff79e19

sebelga changed the title ~~Initial commit~~ [UA] ES deprecation logs in its own page Nov 16, 2021

sabarasaba mentioned this pull request Nov 16, 2021

[Upgrade Assistant] Move fix deprecation logs into the es_deprecation_logs page #118688

Merged

[Upgrade Assistant] Move fix deprecation logs into the es_deprecation…

bacfa21

…_logs page (#118688) * Remove step completion logic and move fix_deprecation_logs folder to es_deprecation_logs * commit using @elastic.co

sebelga added Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.0 v8.0.0 labels Nov 16, 2021

Add new page for the deprecation logs (#118722)

384f5f2

cjcenizal requested a review from debadair November 16, 2021 20:44

debadair reviewed Nov 16, 2021

View reviewed changes

sabarasaba mentioned this pull request Nov 17, 2021

[Upgrade Assistant] Fix cits, a11y and functional tests #118778

Merged

sebelga and others added 2 commits November 17, 2021 09:39

Copy text review

cbce38b

Co-authored-by: debadair <debadair@elastic.co>

[Upgrade Assistant] Fix cits, a11y and functional tests (#118778)

1121331

sebelga marked this pull request as ready for review November 17, 2021 23:05

sebelga requested a review from sabarasaba November 17, 2021 23:05

sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Nov 17, 2021

Document how interstitials are tested

6b40383

sabarasaba approved these changes Nov 18, 2021

View reviewed changes

debadair approved these changes Nov 18, 2021

View reviewed changes

sebelga and others added 2 commits November 18, 2021 18:16

Copy text review

566856b

Co-authored-by: debadair <debadair@elastic.co>

Merge remote-tracking branch 'upstream/7.16' into ua/deprecation_logs…

fb171d4

…_improvements

Fix i18n issues

3808d0e

sebelga merged commit 0770911 into 7.16 Nov 19, 2021

sebelga deleted the ua/deprecation_logs_improvements branch November 19, 2021 08:09

sebelga added a commit that referenced this pull request Nov 19, 2021

[UA] ES deprecation logs in its own page (#118659)

4cd9292

sebelga mentioned this pull request Nov 19, 2021

[main] [UA] ES deprecation logs in its own page (#118659) #119134

Merged

cjcenizal added the v8.1.0 label Nov 19, 2021

sebelga added a commit that referenced this pull request Nov 20, 2021

[main] [UA] ES deprecation logs in its own page (#118659) (#119134)

9fa409f

sebelga mentioned this pull request Nov 22, 2021

[8.0] [UA] ES deprecation logs in its own page (#118659) (#119134) #119345

Merged

sebelga added a commit that referenced this pull request Nov 22, 2021

[8.0] [UA] ES deprecation logs in its own page (#118659) (#119134) (#…

e24749a

…119345)

dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021

[main] [UA] ES deprecation logs in its own page (#118659) (#119134)

0987dae

TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021

[main] [UA] ES deprecation logs in its own page (elastic#118659) (ela…

3631b92

…stic#119134)

gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022

[main] [UA] ES deprecation logs in its own page (elastic#118659) (ela…

08da16f

…stic#119134)

droberts195 mentioned this pull request Jan 28, 2022

After upgrading to 8.0.0 rc2, error is thrown when editing watchers created in 6.8.23 elastic/elasticsearch#83235

Closed

cjcenizal mentioned this pull request Feb 16, 2022

Increase prominence of deprecation logs in Upgrade Assistant #125842

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UA] ES deprecation logs in its own page #118659

[UA] ES deprecation logs in its own page #118659

sebelga commented Nov 16, 2021 •

edited by sabarasaba

Loading

debadair left a comment

cjcenizal commented Nov 17, 2021

cjcenizal commented Nov 17, 2021

elasticmachine commented Nov 17, 2021

sabarasaba left a comment

sebelga commented Nov 18, 2021

debadair left a comment

sebelga commented Nov 18, 2021

kibana-ci commented Nov 18, 2021

cjcenizal commented Nov 19, 2021

sebelga commented Nov 22, 2021

cjcenizal commented Nov 22, 2021

sebelga commented Nov 22, 2021

cjcenizal commented Nov 22, 2021

sebelga commented Nov 22, 2021 •

edited

Loading

[UA] ES deprecation logs in its own page #118659

[UA] ES deprecation logs in its own page #118659

Conversation

sebelga commented Nov 16, 2021 • edited by sabarasaba Loading

TODO

Screenshots

debadair left a comment

Choose a reason for hiding this comment

cjcenizal commented Nov 17, 2021

cjcenizal commented Nov 17, 2021

elasticmachine commented Nov 17, 2021

sabarasaba left a comment

Choose a reason for hiding this comment

sebelga commented Nov 18, 2021

debadair left a comment

Choose a reason for hiding this comment

sebelga commented Nov 18, 2021

kibana-ci commented Nov 18, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

cjcenizal commented Nov 19, 2021

sebelga commented Nov 22, 2021

cjcenizal commented Nov 22, 2021

sebelga commented Nov 22, 2021

cjcenizal commented Nov 22, 2021

sebelga commented Nov 22, 2021 • edited Loading

sebelga commented Nov 16, 2021 •

edited by sabarasaba

Loading

sebelga commented Nov 22, 2021 •

edited

Loading