Fix exists or fail check in Lens chart click test #118499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Team:Visualizations
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 15, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 15, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 15, 2021
kibanamachine
added a commit
that referenced
this pull request
Nov 15, 2021
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Nov 17, 2021
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 19, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
roeehub
pushed a commit
to build-security/kibana
that referenced
this pull request
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117770
The previous fix in #118308 had a problem - the inner
existOrFailwould retry for time itself for too long to actually trigger the outerretry.try. This sets the innerexistOrFailtimeout to a more reasonable value.