Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip lens dashboard tests #118308

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Conversation

flash1293
Copy link
Contributor

Fixes #117770

Sometimes the click on the chart is not registered. This PR makes sure to retry the click until the filter popover appears.

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 11, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review November 11, 2021 12:24
@flash1293 flash1293 requested a review from a team as a code owner November 11, 2021 12:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always in favor of retry :D LGTM!

@flash1293
Copy link
Contributor Author

@flash1293 flash1293 merged commit 0847362 into elastic:main Nov 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 12, 2021
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 12, 2021
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 v8.1.0
Projects
None yet
4 participants