Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Run Jest tests in parallel #117188

Merged
merged 15 commits into from
Nov 9, 2021
Merged

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Nov 2, 2021

A second attempt at #115687 after reverting due to an OOM not causing the job to fail.

This was caused by exitCode not being updated as it was in a subshell.


security_solution/public tests take a really long time to complete (>45 minutes). Until we have a smarter way of dividing the tests I have added a Jest config for each directory under public to split it up.

security_solution/sever is unable to complete as it OOM's. The issue with this has been raised here. In the meantime, I found that splitting up server in the same way as public gets around this issue for now.

A test in x-pack/plugins/security_solution/public/common/components/events_viewer/events_viewer.test.tsx was making Jest exit 1, even though the tests were successful. I have opened #117586 to track re-enabling this test.

* [ci] Run Jest tests in parallel

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Disable coverage

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Make hourly match prs

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Update timeout

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* mock process.execArgv so that it is consistent

* Remove comment

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
@tylersmalley tylersmalley force-pushed the split-jest-2 branch 2 times, most recently from 429cfea to 73630b6 Compare November 2, 2021 17:20
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Tyler Smalley added 2 commits November 2, 2021 12:34
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

Tyler Smalley added 3 commits November 2, 2021 14:31
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Tyler Smalley added 2 commits November 2, 2021 22:32
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Tyler Smalley added 2 commits November 4, 2021 12:54
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley marked this pull request as ready for review November 4, 2021 22:27
@tylersmalley tylersmalley requested review from a team as code owners November 4, 2021 22:27
@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor Author

Going to merge ahead of pending reviews as the bulk of this was approved in the first attempt. The security solution team has reviewed which was the change between these two PR's.

@tylersmalley tylersmalley merged commit 139a3c9 into elastic:main Nov 9, 2021
@tylersmalley tylersmalley deleted the split-jest-2 branch November 9, 2021 19:25
@tylersmalley tylersmalley added auto-backport Deprecated - use backport:version if exact versions are needed v8.0.0 labels Nov 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 10, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 10, 2021
* [ci] Run Jest tests in parallel (#117188)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Skip failing test

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Nov 10, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Nov 10, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 12, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 19, 2021
tylersmalley pushed a commit that referenced this pull request Nov 19, 2021
* [ci] Run Jest tests in parallel (#117188)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* [jest] Fix snapshot caused by environment (#118114)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Add configs

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants