Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jest] Fix snapshot caused by environment #118114

Merged
merged 2 commits into from
Nov 10, 2021
Merged

[jest] Fix snapshot caused by environment #118114

merged 2 commits into from
Nov 10, 2021

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Nov 9, 2021 •
edited
Loading

Unskips test and makes it consistent.

Tyler Smalley added 2 commits November 9, 2021 15:15
[jest] Updates snapshot to be less effected by env
d0bea4f 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Re-enable test
847a1f0 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0 labels Nov 10, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley changed the title [jest] Updates snapshot to be less effected by env [jest] Fix snapshot caused by environment Nov 10, 2021
@tylersmalley tylersmalley marked this pull request as ready for review November 10, 2021 02:09
@tylersmalley tylersmalley requested a review from a team as a code owner November 10, 2021 02:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley merged commit 92ffb9e into elastic:main Nov 10, 2021
@tylersmalley tylersmalley deleted the fix-jest-test branch November 10, 2021 04:27
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Nov 10, 2021
@kpatticha
[jest] Fix snapshot caused by environment (elastic#118114)
4bf70d8 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@jbudz jbudz mentioned this pull request Nov 11, 2021
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 12, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118114 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118114 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118114 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 118114 or prevent reminders by adding the backport:skip label.

@tylersmalley tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 17, 2021
@kibanamachine kibanamachine mentioned this pull request Nov 17, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 17, 2021
@kibanamachine
[jest] Fix snapshot caused by environment (elastic#118114)
142ed95 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 17, 2021
@kibanamachine
[jest] Fix snapshot caused by environment (#118114) (#118833)
29e5f2c 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 17, 2021
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
@fkanout
[jest] Fix snapshot caused by environment (elastic#118114)
b8cb25b 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Nov 18, 2021
[jest] Fix snapshot caused by environment (elastic#118114)
0bc2991 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley mentioned this pull request Nov 18, 2021
Merged
tylersmalley pushed a commit that referenced this pull request Nov 19, 2021
[7.16] [ci] Run Jest tests in parallel (#117188) (#118244)
28022c8 
* [ci] Run Jest tests in parallel (#117188)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* [jest] Fix snapshot caused by environment (#118114)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Add configs

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
[jest] Fix snapshot caused by environment (elastic#118114)
81a8e57 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylersmalley @kibanamachine @elasticmachine @brianseeders