[ML] Data view loading refactor #116455
Merged
[ML] Data view loading refactor #116455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
jgowdyelastic
added
:ml
review
auto-backport
|
Pinging @elastic/ml-ui (:ml) |
...ugins/ml/public/application/jobs/new_job/pages/index_or_search/preconfigured_job_redirect.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
peteharverson
approved these changes
Nov 2, 2021
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 3, 2021
* [ML] Data view loading refactor * more renaming * more renaming * fixing tests * fixing jest test * small changes based on review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 task
kibanamachine
added a commit
that referenced
this pull request
Nov 9, 2021
* [ML] Data view loading refactor * more renaming * more renaming * fixing tests * fixing jest test * small changes based on review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine
removed
the
backport missing
peteharverson
added
release_note:enhancement
and removed
release_note:fix
bug
jgowdyelastic
added a commit
that referenced
this pull request
Jan 17, 2023
…147916) Fixes #147886 by manually checking whether the index behind a data view actually exists before fetching it. This fixes the issue with the data view service which displays a toast for every data view which it cannot load the fields for. This fix has the potential to increase the amount of requests to es by quite a large amount. For example, if a user has 100 data views, 80 of which have existing indices. 1 request is made to load all data view ids and titles 100 requests are made to fetch the fields for each index. 80 succeed. 80 requests are then made to fetch each data view. In 8.0 this behaviour has been [changed](#116455). We no longer request all of the data views up front on page load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the cache of data views (
indexPatternCache) which was populated on first page load of a number of ML pages. Loaded via the client side router.Our recent change to the data view service's
findfunction using a wildcard to load every data view was causing excessive calls to the_fields_for_wildcard, one for each requested data view.Previously we had been using the saved object service's find function which did not also load all of the fields for each requested data view.
This PR removes this call to
findas almost all places where the cache was being used, the full data view saved objects with fields were not needed, rather a list of data view names or a match of name to id.These have been now all been changed to async calls to the real data view data via the data view service.
The rest of the changes in this PR are variable and function identifier changes, index pattern -> data view.
There are still a lot remaining "index patterns" in our code base that I have left be, so not to double the size of this PR and lose focus of the
_fields_for_wildcardproblem it is solving.Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately