more renaming

x-pack/plugins/ml/public/application/datavisualizer/file_based/file_datavisualizer.tsx

@@ -30,7 +30,7 @@ export const FileDataVisualizerPage: FC = () => {
       docLinks,
       dataVisualizer,
       data: {
-        indexPatterns: { get: getIndexPattern },
+        dataViews: { get: getDataView },
       },
     },
   } = useMlKibana();
@@ -60,7 +60,7 @@ export const FileDataVisualizerPage: FC = () => {
         },
         canDisplay: async ({ indexPatternId }) => {
           try {
-            const { timeFieldName } = await getIndexPattern(indexPatternId);
+            const { timeFieldName } = await getDataView(indexPatternId);
             return (
               isFullLicense() &&
               timeFieldName !== undefined &&

x-pack/plugins/ml/public/application/datavisualizer/index_based/index_data_visualizer.tsx

@@ -29,7 +29,7 @@ export const IndexDataVisualizerPage: FC = () => {
       docLinks,
       dataVisualizer,
       data: {
-        indexPatterns: { get: getIndexPattern },
+        dataViews: { get: getDataView },
       },
     },
   } = useMlKibana();
@@ -74,7 +74,7 @@ export const IndexDataVisualizerPage: FC = () => {
         },
         canDisplay: async ({ indexPatternId }) => {
           try {
-            const { timeFieldName } = await getIndexPattern(indexPatternId);
+            const { timeFieldName } = await getDataView(indexPatternId);
             return (
               isFullLicense() &&
               timeFieldName !== undefined &&

x-pack/plugins/ml/public/application/jobs/new_job/recognize/resolvers.ts

@@ -19,7 +19,7 @@ import { CreateLinkWithUserDefaults } from '../../../components/custom_hooks/use
  */
 export function checkViewOrCreateJobs(
   moduleId: string,
-  indexPatternId: string,
+  dataViewId: string,
   createLinkWithUserDefaults: CreateLinkWithUserDefaults,
   navigateToPath: NavigateToPath
 ): Promise<any> {
@@ -36,7 +36,7 @@ export function checkViewOrCreateJobs(
           await navigateToPath(url);
           reject();
         } else {
-          await navigateToPath(`/jobs/new_job/recognize?id=${moduleId}&index=${indexPatternId}`);
+          await navigateToPath(`/jobs/new_job/recognize?id=${moduleId}&index=${dataViewId}`);
           reject();
         }
       })

x-pack/plugins/ml/public/application/routing/routes/new_job/recognize.tsx

@@ -68,7 +68,7 @@ const PageWrapper: FC<PageProps> = ({ location, deps }) => {
 };
 
 const CheckViewOrCreateWrapper: FC<PageProps> = ({ location, deps }) => {
-  const { id: moduleId, index: indexPatternId }: Record<string, any> = parse(location.search, {
+  const { id: moduleId, index: dataViewId }: Record<string, any> = parse(location.search, {
     sort: false,
   });
   const { createLinkWithUserDefaults } = useCreateADLinks();
@@ -78,7 +78,7 @@ const CheckViewOrCreateWrapper: FC<PageProps> = ({ location, deps }) => {
   // the single resolver checkViewOrCreateJobs redirects only. so will always reject
   useResolver(undefined, undefined, deps.config, deps.dataViewsContract, {
     checkViewOrCreateJobs: () =>
-      checkViewOrCreateJobs(moduleId, indexPatternId, createLinkWithUserDefaults, navigateToPath),
+      checkViewOrCreateJobs(moduleId, dataViewId, createLinkWithUserDefaults, navigateToPath),
   });
   return null;
 };

x-pack/plugins/ml/public/application/routing/use_resolver.test.ts

@@ -45,7 +45,7 @@ describe('useResolver', () => {
     jest.useRealTimers();
   });
 
-  it('should accept undefined as indexPatternId and savedSearchId.', async () => {
+  it('should accept undefined as dataViewId and savedSearchId.', async () => {
     const { result, waitForNextUpdate } = renderHook(() =>
       useResolver(undefined, undefined, {} as IUiSettingsClient, {} as DataViewsContract, {})
     );
@@ -76,7 +76,7 @@ describe('useResolver', () => {
     expect(redirectToJobsManagementPage).toHaveBeenCalledTimes(0);
   });
 
-  it('should add an error toast and redirect if indexPatternId is an empty string.', async () => {
+  it('should add an error toast and redirect if dataViewId is an empty string.', async () => {
     const { result } = renderHook(() =>
       useResolver('', undefined, {} as IUiSettingsClient, {} as DataViewsContract, {})
     );

x-pack/plugins/ml/server/models/data_frame_analytics/index_patterns.ts

@@ -7,17 +7,17 @@
 
 import { DataViewsService } from '../../../../../../src/plugins/data_views/common';
 
-export class IndexPatternHandler {
+export class DataViewHandler {
   constructor(private dataViewService: DataViewsService) {}
   // returns a id based on an index pattern name
-  async getIndexPatternId(indexName: string) {
+  async getDataViewId(indexName: string) {
     const dv = (await this.dataViewService.find(indexName)).find(
       ({ title }) => title === indexName
     );
     return dv?.id;
   }
 
-  async deleteIndexPatternById(indexId: string) {
-    return await this.dataViewService.delete(indexId);
+  async deleteDataViewById(dataViewId: string) {
+    return await this.dataViewService.delete(dataViewId);
   }
 }

x-pack/plugins/ml/server/routes/data_frame_analytics.ts

@@ -29,7 +29,7 @@ import type {
   GetAnalyticsMapArgs,
   ExtendAnalyticsMapArgs,
 } from '../models/data_frame_analytics/types';
-import { IndexPatternHandler } from '../models/data_frame_analytics/index_patterns';
+import { DataViewHandler } from '../models/data_frame_analytics/index_patterns';
 import { AnalyticsManager } from '../models/data_frame_analytics/analytics_manager';
 import { validateAnalyticsJob } from '../models/data_frame_analytics/validation';
 import { fieldServiceProvider } from '../models/job_service/new_job_caps/field_service';
@@ -38,14 +38,14 @@ import { getAuthorizationHeader } from '../lib/request_authorization';
 import type { MlClient } from '../lib/ml_client';
 import type { DataViewsService } from '../../../../../src/plugins/data_views/common';
 
-function getIndexPatternId(dataViewsService: DataViewsService, patternName: string) {
-  const iph = new IndexPatternHandler(dataViewsService);
-  return iph.getIndexPatternId(patternName);
+function getDataVIewId(dataViewsService: DataViewsService, patternName: string) {
+  const iph = new DataViewHandler(dataViewsService);
+  return iph.getDataViewId(patternName);
 }
 
-function deleteDestIndexPatternById(dataViewsService: DataViewsService, indexPatternId: string) {
-  const iph = new IndexPatternHandler(dataViewsService);
-  return iph.deleteIndexPatternById(indexPatternId);
+function deleteDestDataViewById(dataViewsService: DataViewsService, dataViewId: string) {
+  const iph = new DataViewHandler(dataViewsService);
+  return iph.deleteDataViewById(dataViewId);
 }
 
 function getAnalyticsMap(
@@ -427,9 +427,9 @@ export function dataFrameAnalyticsRoutes({ router, mlLicense, routeGuard }: Rout
             if (destinationIndex && deleteDestIndexPattern) {
               try {
                 const dataViewsService = await getDataViewsService();
-                const indexPatternId = await getIndexPatternId(dataViewsService, destinationIndex);
-                if (indexPatternId) {
-                  await deleteDestIndexPatternById(dataViewsService, indexPatternId);
+                const dataViewId = await getDataVIewId(dataViewsService, destinationIndex);
+                if (dataViewId) {
+                  await deleteDestDataViewById(dataViewsService, dataViewId);
                 }
                 destIndexPatternDeleted.success = true;
               } catch (deleteDestIndexPatternError) {