Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fleet] Tweak Header UI #114704

Merged
merged 5 commits into from
Oct 13, 2021
Merged

[fleet] Tweak Header UI #114704

merged 5 commits into from
Oct 13, 2021

Conversation

clintandrewhall
Copy link
Contributor

Summary

Updates the header in Fleet to match the Figma design:

  • Properly align hero image
  • Update header text
  • Add doc link

Screen Shot 2021-10-12 at 1 08 52 PM

@clintandrewhall clintandrewhall requested review from a team as code owners October 12, 2021 18:11
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@clintandrewhall clintandrewhall added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Unified Integrations Unified Integrations view feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort review v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 12, 2021
lukeelmers
lukeelmers approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclinks changes lgtm - just had one suggestion

src/core/public/doc_links/doc_links_service.ts Outdated
@@ -477,6 +478,7 @@ export class DocLinksService {
upgradeElasticAgent: `${FLEET_DOCS}upgrade-elastic-agent.html`,
upgradeElasticAgent712lower: `${FLEET_DOCS}upgrade-elastic-agent.html#upgrade-7.12-lower`,
learnMoreBlog: `${ELASTIC_WEBSITE_URL}blog/elastic-agent-and-fleet-make-it-easier-to-integrate-your-systems-with-elastic`,
elasticStackGetStarted: `${STACK_GETTING_STARTED}get-started-elastic-stack.html`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I might consider moving this out of fleet since it isn't specific to that domain. Maybe just a top level links.stackGettingStarted or similar.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 626.1KB 626.5KB +371.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 301.0KB 301.2KB +109.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall enabled auto-merge (squash) October 13, 2021 04:38
juliaElastic
juliaElastic approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clintandrewhall clintandrewhall merged commit db4bcde into elastic:master Oct 13, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 114704

jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reportingg/gu…
32c6f05 
…ide-users-to-saving-ux

* 'master' of github.com:elastic/kibana: (133 commits)
  [DOCS] Indicate reports are a subscription feature (elastic#114653)
  Update namespace for indices (elastic#114612)
  [DOCS] Adds Logstash pipeline settings (elastic#114648)
  Bump EPR snapshot version used for tests (elastic#114529)
  [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291)
  skip flaky suite (elastic#68400)
  [Visualizations] fix usage of optional dependencies (elastic#114286)
  [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454)
  [fleet] Add Integration Preference selector (elastic#114432)
  [Reporting] Add new `data-render-error` attribute (elastic#114472)
  Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316)
  [data views] add getDefaultDataView method  (elastic#113891)
  [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126)
  [fleet] Tweak Header UI (elastic#114704)
  [APM] Filter on tx metrics for instance stats (elastic#114758)
  [APM] Fix typo in linting docs (elastic#114764)
  [Discover] Removing SavedObject usage for savedSearch (elastic#112983)
  [Fleet] Add Integration Policy Page Improvements (elastic#114556)
  [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270)
  [Security Solution][Endpoint] Host Isolation API changes (elastic#113621)
  ...
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Oct 14, 2021
@clintandrewhall @thomasneirynck
[fleet] Tweak Header UI (elastic#114704)
0020c3b
@thomasneirynck thomasneirynck mentioned this pull request Oct 14, 2021
Merged
thomasneirynck added a commit that referenced this pull request Oct 14, 2021
@thomasneirynck @clintandrewhall
[fleet] Tweak Header UI (#114704) (#115079)
328b69d 
Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co>
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
@clintandrewhall @artem-shelkovnikov
[fleet] Tweak Header UI (elastic#114704)
526632c
@clintandrewhall clintandrewhall deleted the fleet/ui-tweaks branch December 29, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

@dborodyansky dborodyansky Awaiting requested review from dborodyansky

@thomasneirynck thomasneirynck Awaiting requested review from thomasneirynck

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Unified Integrations Unified Integrations view feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clintandrewhall @elasticmachine @kibanamachine @lukeelmers @juliaElastic