Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Endpoint] Fleet summary card adjustments #114291

Merged
merged 5 commits into from
Oct 13, 2021
Merged

[Security Solution] [Endpoint] Fleet summary card adjustments #114291

merged 5 commits into from
Oct 13, 2021

Conversation

dasansol92
Copy link
Contributor

@dasansol92 dasansol92 commented Oct 7, 2021 •
edited
Loading

Summary

  • Fix API call - missed parents.
  • Adjust design when is small - displays only the total count:

Screenshot 2021-10-13 at 12 47 13

For maintainers

@dasansol92 dasansol92 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 7, 2021
paul-tavares
paul-tavares approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dasansol92 dasansol92 marked this pull request as ready for review October 13, 2021 07:54
@dasansol92 dasansol92 requested a review from a team as a code owner October 13, 2021 07:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@dasansol92 dasansol92 marked this pull request as draft October 13, 2021 07:54
@dasansol92
Copy link
Contributor Author

@elasticmachine merge upstream

academo
academo approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@academo academo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You get a 🐑 of approval.

Suggestion: is there an unit test you can add to cover the isSmall case?

@dasansol92
Copy link
Contributor Author

@academo @paul-tavares Did a small refactor in fleet-trusted-apps-card component

@dasansol92 dasansol92 marked this pull request as ready for review October 13, 2021 10:47
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +972.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares
paul-tavares reviewed Oct 13, 2021
View reviewed changes
...ngest_manager_integration/endpoint_package_custom_extension/components/styled_components.tsx
@@ -25,3 +22,7 @@ export const StyledEuiFlexGridItem = styled(EuiFlexItem)<{
margin: 0px;
padding: 12px;
`;

export const StyledEuiFlexItem = styled(EuiFlexItem)`
flex-direction: row-reverse;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that EuiFlexItem allowed you to do this via a prop already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not, only for the EuiFlexGroup one.

paul-tavares
paul-tavares approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but 👍 🚢

@dasansol92 dasansol92 merged commit b86bf83 into elastic:master Oct 13, 2021
@kibanamachine kibanamachine mentioned this pull request Oct 13, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 13, 2021
@dasansol92 @kibanamachine
[Security Solution] [Endpoint] Fleet summary card adjustments (elasti…
b645679 
…c#114291)

* Fix API call and refactor component to show different summary when size is small

* Refactored fleet trusted app card with new m design

* Removed unused code

* fix ts error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reportingg/gu…
32c6f05 
…ide-users-to-saving-ux

* 'master' of github.com:elastic/kibana: (133 commits)
  [DOCS] Indicate reports are a subscription feature (elastic#114653)
  Update namespace for indices (elastic#114612)
  [DOCS] Adds Logstash pipeline settings (elastic#114648)
  Bump EPR snapshot version used for tests (elastic#114529)
  [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291)
  skip flaky suite (elastic#68400)
  [Visualizations] fix usage of optional dependencies (elastic#114286)
  [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454)
  [fleet] Add Integration Preference selector (elastic#114432)
  [Reporting] Add new `data-render-error` attribute (elastic#114472)
  Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316)
  [data views] add getDefaultDataView method  (elastic#113891)
  [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126)
  [fleet] Tweak Header UI (elastic#114704)
  [APM] Filter on tx metrics for instance stats (elastic#114758)
  [APM] Fix typo in linting docs (elastic#114764)
  [Discover] Removing SavedObject usage for savedSearch (elastic#112983)
  [Fleet] Add Integration Policy Page Improvements (elastic#114556)
  [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270)
  [Security Solution][Endpoint] Host Isolation API changes (elastic#113621)
  ...
kibanamachine added a commit that referenced this pull request Oct 13, 2021
@kibanamachine @dasansol92
[Security Solution] [Endpoint] Fleet summary card adjustments (#114291)…
dc7b8fb 
… (#114826)

* Fix API call and refactor component to show different summary when size is small

* Refactored fleet trusted app card with new m design

* Removed unused code

* fix ts error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: David Sánchez <davidsansol92@gmail.com>
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
@dasansol92 @kibanamachine @artem-shelkovnikov
[Security Solution] [Endpoint] Fleet summary card adjustments (elasti…
f7a30f8 
…c#114291)

* Fix API call and refactor component to show different summary when size is small

* Refactored fleet trusted app card with new m design

* Removed unused code

* fix ts error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@academo academo academo approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dasansol92 @elasticmachine @kibanamachine @academo @paul-tavares