Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documents es/so/server deprecated settings removal in breaking changes #113337

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Documents es/so/server deprecated settings removal in breaking changes #113337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f2ac41
Documents es/so/server deprecated settings removal in breaking changes
TinaHeiligers Sep 28, 2021
1d996ee
fixes linked text to ref
TinaHeiligers Sep 28, 2021
a6be394
Fix links
TinaHeiligers Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/migration/migrate_8_0.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,4 +338,24 @@ The output directory after extracting an archive no longer includes the target p
*Impact:*
Configuration management tools and automation will need to be updated to use the new directory.

[float]
=== `elasticsearch.preserveHost` is no longer valid
*Details:* The deprecated `elasticsearch.preserveHost` setting in the `kibana.yml` file has been removed.

*Impact:* Configure {kibana-ref}/settings.html#elasticsearch-requestHeadersWhitelist[`elasticsearch.requestHeadersWhitelist`] to whitelist client-side headers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I know the term is used in the setting name anyway, but we may still want to use another term than whitelist in the text?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on hold with this effort for the public API. Aren't we? #71398 (comment)
Anyway, it's too late to deprecate them for v8.0. We can postpone this work until after 8.0. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it's too late. I was just asking if it would make sense to use another term in the details section's description. But that's probably not worth it given that the same term is used in the setting's name anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and get this in, then we can revisit it once all the deprecations are handled (removed).


[float]
=== `elasticsearch.startupTimeout` is no longer valid
*Details:* The deprecated `elasticsearch.startupTimeout` setting in the `kibana.yml` file has been removed.

*Impact:* Kibana will keep on trying to connect to Elasticsearch until it manages to connect.

[float]
=== `savedObjects.indexCheckTimeout` is no longer valid
*Details:* The deprecated `savedObjects.indexCheckTimeout` setting in the `kibana.yml` file has been removed.

[float]
=== `server.xsrf.token` is no longer valid
*Details:* The deprecated `server.xsrf.token` setting in the `kibana.yml` file has been removed.

// end::notable-breaking-changes[]