Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents es/so/server deprecated settings removal in breaking changes #113337

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Sep 28, 2021

Adds docs for #113173.
Related to #103915

Screen shots (docs)

In breaking changes in 8.0:

Screen Shot 2021-09-28 at 15 26 40

To reviewers:
I tried to find alternative settings for each of these but hit a dead-end for savedObjects.indexCheckTimeout and server.xsrf.token during the platform migration.

The semi-alternative setting for elasticsearch.preserveHost comes from #17237 (comment)

Checklist

  • Documentation was added for features that require explanation or tutorials

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 backport:skip This commit does not require backporting docs labels Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers added the release_note:skip Skip the PR/issue when compiling release notes label Sep 28, 2021
@TinaHeiligers TinaHeiligers requested a review from a team September 28, 2021 21:33
=== `elasticsearch.preserveHost` is no longer valid
*Details:* The deprecated `elasticsearch.preserveHost` setting in the `kibana.yml` file has been removed.

*Impact:* Configure {kibana-ref}/settings.html#elasticsearch-requestHeadersWhitelist[`elasticsearch.requestHeadersWhitelist`] to whitelist client-side headers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I know the term is used in the setting name anyway, but we may still want to use another term than whitelist in the text?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on hold with this effort for the public API. Aren't we? #71398 (comment)
Anyway, it's too late to deprecate them for v8.0. We can postpone this work until after 8.0. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it's too late. I was just asking if it would make sense to use another term in the details section's description. But that's probably not worth it given that the same term is used in the setting's name anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and get this in, then we can revisit it once all the deprecations are handled (removed).

@TinaHeiligers TinaHeiligers merged commit 5cf733a into elastic:master Sep 29, 2021
@TinaHeiligers TinaHeiligers deleted the config-breaking/remove-deprecated-config-misc-docs branch September 29, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants