-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Rename Index pattern to Data view #110402
Changes from 3 commits
f5557ee
ae5feca
d339a0d
ac1fd48
f22e5f9
d5616d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,8 +107,8 @@ export function resolveIndexPattern( | |
} | ||
|
||
if (stateVal && !stateValFound) { | ||
const warningTitle = i18n.translate('discover.valueIsNotConfiguredIndexPatternIDWarningTitle', { | ||
defaultMessage: '{stateVal} is not a configured index pattern ID', | ||
const warningTitle = i18n.translate('discover.valueIsNotConfiguredDataViewIDWarningTitle', { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should be changing the keys just yet. I would leave this for a code-cleanup phase. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess it's fine as in other renaming PRs keys were updated too There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agree with Dziana here, let's keep it as it |
||
defaultMessage: '{stateVal} is not a configured data view ID', | ||
values: { | ||
stateVal: `"${stateVal}"`, | ||
}, | ||
|
@@ -117,9 +117,9 @@ export function resolveIndexPattern( | |
if (ownIndexPattern) { | ||
toastNotifications.addWarning({ | ||
title: warningTitle, | ||
text: i18n.translate('discover.showingSavedIndexPatternWarningDescription', { | ||
text: i18n.translate('discover.showingSavedDataViewWarningDescription', { | ||
defaultMessage: | ||
'Showing the saved index pattern: "{ownIndexPatternTitle}" ({ownIndexPatternId})', | ||
'Showing the saved data view: "{ownIndexPatternTitle}" ({ownIndexPatternId})', | ||
values: { | ||
ownIndexPatternTitle: ownIndexPattern.title, | ||
ownIndexPatternId: ownIndexPattern.id, | ||
|
@@ -131,9 +131,9 @@ export function resolveIndexPattern( | |
|
||
toastNotifications.addWarning({ | ||
title: warningTitle, | ||
text: i18n.translate('discover.showingDefaultIndexPatternWarningDescription', { | ||
text: i18n.translate('discover.showingDefaultDataViewWarningDescription', { | ||
defaultMessage: | ||
'Showing the default index pattern: "{loadedIndexPatternTitle}" ({loadedIndexPatternId})', | ||
'Showing the default data view: "{loadedIndexPatternTitle}" ({loadedIndexPatternId})', | ||
values: { | ||
loadedIndexPatternTitle: loadedIndexPattern.title, | ||
loadedIndexPatternId: loadedIndexPattern.id, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is referring to ES index and should not be renamed.