[Discover] Rename Index pattern to Data view #110402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DianaDerevyankina
added
Feature:Discover
timroes
added
Team:DataDiscovery
DianaDerevyankina
added
backport:skip
# Conflicts: # src/plugins/discover/public/application/components/doc/doc.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
|
@elasticmachine merge upstream |
majagrubic
reviewed
Oct 5, 2021
| @@ -98,7 +98,7 @@ export function Doc(props: DocProps) { | |||
| <EuiLink href={indexExistsLink} target="_blank"> | |||
| <FormattedMessage | |||
| id="discover.doc.somethingWentWrongDescriptionAddon" | |||
| defaultMessage="Please ensure the index exists." | |||
| defaultMessage="Please ensure the data view exists." | |||
There was a problem hiding this comment.
This is referring to ES index and should not be renamed.
majagrubic
reviewed
Oct 5, 2021
| @@ -107,8 +107,8 @@ export function resolveIndexPattern( | |||
| } | |||
|
|
|||
| if (stateVal && !stateValFound) { | |||
| const warningTitle = i18n.translate('discover.valueIsNotConfiguredIndexPatternIDWarningTitle', { | |||
| defaultMessage: '{stateVal} is not a configured index pattern ID', | |||
| const warningTitle = i18n.translate('discover.valueIsNotConfiguredDataViewIDWarningTitle', { | |||
There was a problem hiding this comment.
I don't think we should be changing the keys just yet. I would leave this for a code-cleanup phase.
There was a problem hiding this comment.
I guess it's fine as in other renaming PRs keys were updated too
There was a problem hiding this comment.
Agree with Dziana here, let's keep it as it
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@elasticmachine merge upstream |
DianaDerevyankina
changed the base branch from
master
to
index_patterns_to_data_views_user_content_feature_branch
DianaDerevyankina
requested review from
pzl and
paul-tavares
and removed request for
a team
DianaDerevyankina
force-pushed
the
discover-index-pattern-to-data-view
branch
from
43a1f38
to
f22e5f9
Compare
…h' into discover-index-pattern-to-data-view
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alexwizp
approved these changes
Oct 8, 2021
DianaDerevyankina
merged commit d393aeb
into
elastic:index_patterns_to_data_views_user_content_feature_branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #114083
Summary
Renamed
index patternstodata viewsin Discover UI.Checklist
For maintainers