Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] fix edit layer settings action showing when readonly #109321

Merged
merged 4 commits into from
Aug 20, 2021
Merged

[Maps] fix edit layer settings action showing when readonly #109321

merged 4 commits into from
Aug 20, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 19, 2021

Fixes regression in 7.14.0 caused by #104797 where "Edit layer settings" action was moved outside of the !readonly if statement.

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.14.1 labels Aug 19, 2021
@nreese nreese requested a review from a team as a code owner August 19, 2021 19:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

thomasneirynck
thomasneirynck approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙏

@nreese
Copy link
Contributor Author

nreese commented Aug 19, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Aug 19, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/drag_and_drop·ts.lens app lens drag and drop tests basic drag and drop should construct the basic split xy chart

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 7 times on tracked branches: https://github.com/elastic/kibana/issues/108352

[00:00:00]       │
[00:10:50]         └-: lens app
[00:10:50]           └-> "before all" hook in "lens app"
[00:10:50]           └-> "before all" hook in "lens app"
[00:10:50]             │ debg Starting lens before method
[00:10:50]             │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "mappings.json"
[00:10:50]             │ info [x-pack/test/functional/es_archives/logstash_functional] Loading "data.json.gz"
[00:10:50]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [logstash-2015.09.22/iUgaCHhqSTOy89QK4JOc_w] deleting index
[00:10:50]             │ info [x-pack/test/functional/es_archives/logstash_functional] Deleted existing index "logstash-2015.09.22"
[00:10:50]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:10:50]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.22"
[00:10:50]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:10:50]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [logstash-2015.09.20/WDsum5o2RpiGmV6NmwBfhw] deleting index
[00:10:51]             │ info [x-pack/test/functional/es_archives/logstash_functional] Deleted existing index "logstash-2015.09.20"
[00:10:51]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:10:51]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.20"
[00:10:51]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:10:51]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [logstash-2015.09.21/jFJaMnHwQJOtKr72mC_P2A] deleting index
[00:10:51]             │ info [x-pack/test/functional/es_archives/logstash_functional] Deleted existing index "logstash-2015.09.21"
[00:10:51]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:10:51]             │ info [x-pack/test/functional/es_archives/logstash_functional] Created index "logstash-2015.09.21"
[00:10:51]             │ debg [x-pack/test/functional/es_archives/logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:10:51]             │ info [o.e.c.m.MetadataMappingService] [node-01] [logstash-2015.09.21/6VYDzNjoSbm0_h-asd4hHA] update_mapping [_doc]
[00:10:54]             │ info [o.e.c.m.MetadataMappingService] [node-01] [logstash-2015.09.20/lwpARL5DQCKIPIBKlx3Kww] update_mapping [_doc]
[00:11:00]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:11:00]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:11:00]             │ info [x-pack/test/functional/es_archives/logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:11:00]             │ info [x-pack/test/functional/es_archives/lens/basic] Loading "mappings.json"
[00:11:00]             │ info [x-pack/test/functional/es_archives/lens/basic] Loading "data.json"
[00:11:00]             │ info [x-pack/test/functional/es_archives/lens/basic] Loading "data.json.gz"
[00:11:00]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_task_manager_8.0.0_001/jajb3vbaR1ebQ3E_L36NOA] deleting index
[00:11:00]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_1/p2vG9M8rSfeHXDqZloyd8g] deleting index
[00:11:00]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_001/CMypQg2DROC9Jd9yq0QPIQ] deleting index
[00:11:00]             │ info [x-pack/test/functional/es_archives/lens/basic] Deleted existing index ".kibana_8.0.0_001"
[00:11:00]             │ info [x-pack/test/functional/es_archives/lens/basic] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:11:00]             │ info [x-pack/test/functional/es_archives/lens/basic] Deleted existing index ".kibana_1"
[00:11:00]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:11:01]             │ info [x-pack/test/functional/es_archives/lens/basic] Created index ".kibana_1"
[00:11:01]             │ debg [x-pack/test/functional/es_archives/lens/basic] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:11:01]             │ info [x-pack/test/functional/es_archives/lens/basic] Indexed 24 docs into ".kibana_1"
[00:11:01]             │ debg Migrating saved objects
[00:11:01]             │ proc [kibana]   log   [22:31:40.964] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 2ms.
[00:11:01]             │ proc [kibana]   log   [22:31:40.967] [info][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 8ms.
[00:11:01]             │ proc [kibana]   log   [22:31:40.969] [info][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> CHECK_UNKNOWN_DOCUMENTS. took: 2ms.
[00:11:01]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:11:01]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:11:01]             │ proc [kibana]   log   [22:31:40.974] [info][savedobjects-service] [.kibana] CHECK_UNKNOWN_DOCUMENTS -> SET_SOURCE_WRITE_BLOCK. took: 5ms.
[00:11:01]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_1/gk8lbEqRTkWOeOJzT7lWZg]]
[00:11:01]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_1]
[00:11:01]             │ proc [kibana]   log   [22:31:41.035] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 71ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.049] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CALCULATE_EXCLUDE_FILTERS. took: 75ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.052] [info][savedobjects-service] [.kibana] CALCULATE_EXCLUDE_FILTERS -> CREATE_REINDEX_TEMP. took: 3ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.066] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 31ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.067] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 105ms
[00:11:01]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:11:01]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:11:01]             │ proc [kibana]   log   [22:31:41.111] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 59ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.114] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 3ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.120] [info][savedobjects-service] [.kibana] Starting to process 12 documents.
[00:11:01]             │ proc [kibana]   log   [22:31:41.120] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_INDEX. took: 5ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.146] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 27ms.
[00:11:01]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/aIPEgEa7SjS4i3NvwhvSAA] update_mapping [_doc]
[00:11:01]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/aIPEgEa7SjS4i3NvwhvSAA] update_mapping [_doc]
[00:11:01]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/aIPEgEa7SjS4i3NvwhvSAA] update_mapping [_doc]
[00:11:01]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/aIPEgEa7SjS4i3NvwhvSAA] update_mapping [_doc]
[00:11:01]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/aIPEgEa7SjS4i3NvwhvSAA] update_mapping [_doc]
[00:11:01]             │ proc [kibana]   log   [22:31:41.265] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 119ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.269] [info][savedobjects-service] [.kibana] Processed 12 documents out of 12.
[00:11:01]             │ proc [kibana]   log   [22:31:41.269] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 4ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.271] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 2ms.
[00:11:01]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_8.0.0_reindex_temp/aIPEgEa7SjS4i3NvwhvSAA]]
[00:11:01]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:11:01]             │ proc [kibana]   log   [22:31:41.310] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 39ms.
[00:11:01]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:11:01]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:11:01]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:11:01]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/14nJTm7CT4uN_6ayrr6v-Q] create_mapping
[00:11:01]             │ proc [kibana]   log   [22:31:41.405] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 95ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.408] [info][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 3ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.411] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 3ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.415] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 4ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.417] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 2ms.
[00:11:01]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/14nJTm7CT4uN_6ayrr6v-Q] update_mapping [_doc]
[00:11:01]             │ proc [kibana]   log   [22:31:41.469] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 52ms.
[00:11:01]             │ info [o.e.t.LoggingTaskListener] [node-01] 24492 finished with response BulkByScrollResponse[took=21.6ms,timed_out=false,sliceId=null,updated=12,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:11:01]             │ proc [kibana]   log   [22:31:41.575] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 106ms.
[00:11:01]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_reindex_temp/aIPEgEa7SjS4i3NvwhvSAA] deleting index
[00:11:01]             │ proc [kibana]   log   [22:31:41.613] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 38ms.
[00:11:01]             │ proc [kibana]   log   [22:31:41.613] [info][savedobjects-service] [.kibana] Migration completed after 654ms
[00:11:01]             │ debg [x-pack/test/functional/es_archives/lens/basic] Migrated Kibana index after loading Kibana data
[00:11:01]             │ debg [x-pack/test/functional/es_archives/lens/basic] Ensured that default space exists in .kibana
[00:11:01]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true,"visualization:visualize:legacyPieChartsLibrary":true}
[00:11:03]           └-: 
[00:11:03]             └-> "before all" hook in ""
[01:02:27]             └-: lens drag and drop tests
[01:02:27]               └-> "before all" hook in "lens drag and drop tests"
[01:02:27]               └-: basic drag and drop
[01:02:27]                 └-> "before all" hook for "should construct the basic split xy chart"
[01:02:27]                 └-> should construct the basic split xy chart
[01:02:27]                   └-> "before each" hook: global before each for "should construct the basic split xy chart"
[01:02:27]                   │ debg navigating to visualize url: http://localhost:61181/app/visualize#/
[01:02:27]                   │ debg navigate to: http://localhost:61181/app/visualize#/
[01:02:27]                   │ debg ... sleep(700) start
[01:02:28]                   │ debg browser[INFO] http://localhost:61181/app/visualize?_t=1629415387665#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[01:02:28]                   │
[01:02:28]                   │ debg browser[INFO] http://localhost:61181/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[01:02:28]                   │ debg ... sleep(700) end
[01:02:28]                   │ debg returned from get, calling refresh
[01:02:29]                   │ debg browser[INFO] http://localhost:61181/app/visualize?_t=1629415387665#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[01:02:29]                   │
[01:02:29]                   │ debg browser[INFO] http://localhost:61181/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[01:02:30]                   │ debg currentUrl = http://localhost:61181/app/visualize#/
[01:02:30]                   │          appUrl = http://localhost:61181/app/visualize#/
[01:02:30]                   │ debg TestSubjects.find(kibanaChrome)
[01:02:30]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[01:02:30]                   │ debg ... sleep(501) start
[01:02:30]                   │ debg ... sleep(501) end
[01:02:30]                   │ debg in navigateTo url = http://localhost:61181/app/visualize#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[01:02:30]                   │ debg --- retry.tryForTime error: URL changed, waiting for it to settle
[01:02:31]                   │ debg ... sleep(501) start
[01:02:31]                   │ debg ... sleep(501) end
[01:02:31]                   │ debg in navigateTo url = http://localhost:61181/app/visualize#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[01:02:31]                   │ debg isGlobalLoadingIndicatorVisible
[01:02:31]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[01:02:31]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[01:02:33]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[01:02:33]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[01:02:33]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[01:02:33]                   │ debg TestSubjects.exists(newItemButton)
[01:02:33]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[01:02:33]                   │ debg TestSubjects.click(newItemButton)
[01:02:33]                   │ debg Find.clickByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[01:02:33]                   │ debg Find.findByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[01:02:34]                   │ debg TestSubjects.find(visNewDialogGroups)
[01:02:34]                   │ debg Find.findByCssSelector('[data-test-subj="visNewDialogGroups"]') with timeout=10000
[01:02:34]                   │ debg TestSubjects.click(visType-lens)
[01:02:34]                   │ debg Find.clickByCssSelector('[data-test-subj="visType-lens"]') with timeout=10000
[01:02:34]                   │ debg Find.findByCssSelector('[data-test-subj="visType-lens"]') with timeout=10000
[01:02:34]                   │ debg isGlobalLoadingIndicatorVisible
[01:02:34]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[01:02:34]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[01:02:35]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[01:02:36]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[01:02:36]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[01:02:36]                   │ debg lensPage.goToTimeRange()
[01:02:36]                   │ debg TestSubjects.exists(noDataPopoverDismissButton)
[01:02:36]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="noDataPopoverDismissButton"]') with timeout=2500
[01:02:36]                   │ debg TestSubjects.click(noDataPopoverDismissButton)
[01:02:36]                   │ debg Find.clickByCssSelector('[data-test-subj="noDataPopoverDismissButton"]') with timeout=10000
[01:02:36]                   │ debg Find.findByCssSelector('[data-test-subj="noDataPopoverDismissButton"]') with timeout=10000
[01:02:36]                   │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[01:02:36]                   │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[01:02:36]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[01:02:36]                   │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[01:02:36]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[01:02:36]                   │ debg TestSubjects.click(superDatePickerShowDatesButton)
[01:02:36]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[01:02:36]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[01:02:36]                   │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[01:02:36]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[01:02:36]                   │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[01:02:36]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[01:02:36]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[01:02:36]                   │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[01:02:36]                   │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[01:02:36]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[01:02:36]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[01:02:36]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[01:02:36]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:36]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:37]                   │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[01:02:37]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[01:02:37]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:37]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:37]                   │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[01:02:37]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[01:02:37]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[01:02:37]                   │ debg Find.waitForElementStale with timeout=10000
[01:02:37]                   │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[01:02:37]                   │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[01:02:37]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[01:02:37]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[01:02:37]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[01:02:37]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:37]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:38]                   │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[01:02:38]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[01:02:38]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:38]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[01:02:38]                   │ debg Waiting up to 20000ms for Timepicker popover to close...
[01:02:38]                   │ debg TestSubjects.exists(superDatePickerAbsoluteDateInput)
[01:02:38]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=2500
[01:02:38]                   │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerAbsoluteDateInput"] is not displayed
[01:02:41]                   │ debg --- retry.tryForTime failed again with the same message...
[01:02:42]                   │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[01:02:42]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[01:02:44]                   │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[01:02:45]                   │ debg TestSubjects.click(querySubmitButton)
[01:02:45]                   │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[01:02:45]                   │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[01:02:45]                   │ debg Find.waitForElementStale with timeout=10000
[01:02:45]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[01:02:45]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[01:02:45]                   │ debg isGlobalLoadingIndicatorVisible
[01:02:45]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[01:02:45]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[01:02:45]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[01:02:45]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[01:02:45]                   │ debg lensPage.dragFieldToWorkspace('@timestamp')
[01:02:46]                   │ debg lensPage.waitForLensDragDropToFinish()
[01:02:46]                   │ debg Find.existsByCssSelector('.lnsDragDrop-isActiveGroup') with timeout=2500
[01:02:48]                   │ debg isGlobalLoadingIndicatorVisible
[01:02:48]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[01:02:48]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[01:02:50]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[01:02:50]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[01:02:50]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[01:02:50]                   │ debg lensPage.getDimensionTriggerText('lnsXY_xDimensionPanel')
[01:02:50]                   │ debg lensPage.getDimensionTriggersTexts('lnsXY_xDimensionPanel')
[01:02:50]                   │ debg TestSubjects.findAll(lnsXY_xDimensionPanel > lns-dimensionTrigger)
[01:02:50]                   │ debg Find.allByCssSelector('[data-test-subj="lnsXY_xDimensionPanel"] [data-test-subj="lns-dimensionTrigger"]') with timeout=10000
[01:03:00]                   │ info Taking screenshot "/dev/shm/workspace/parallel/18/kibana/x-pack/test/functional/screenshots/failure/lens app  lens drag and drop tests basic drag and drop should construct the basic split xy chart.png"
[01:03:00]                   │ info Current URL is: http://localhost:61181/app/lens#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))
[01:03:01]                   │ info Saving page source to: /dev/shm/workspace/parallel/18/kibana/x-pack/test/functional/failure_debug/html/lens app  lens drag and drop tests basic drag and drop should construct the basic split xy chart.html
[01:03:01]                   └- ✖ fail: lens app  lens drag and drop tests basic drag and drop should construct the basic split xy chart
[01:03:01]                   │      Error: expected undefined to sort of equal '@timestamp'
[01:03:01]                   │       at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:100:11)
[01:03:01]                   │       at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:244:8)
[01:03:01]                   │       at Context.<anonymous> (test/functional/apps/lens/drag_and_drop.ts:26:92)
[01:03:01]                   │       at runMicrotasks (<anonymous>)
[01:03:01]                   │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[01:03:01]                   │       at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[01:03:01]                   │ 
[01:03:01]                   │

Stack Trace

Error: expected undefined to sort of equal '@timestamp'
    at Assertion.assert (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/functional/apps/lens/drag_and_drop.ts:26:92)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/18/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16) {
  actual: undefined,
  expected: '@timestamp',
  showDiff: true
}

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit c635216 into elastic:master Aug 20, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v7.16.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 20, 2021
@nreese @kibanamachine
[Maps] fix edit layer settings action showing when readonly (elastic#…
f89dd92 
…109321)

* [Maps] fix edit layer settings action showing when readonly

* remove unneeded file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 20, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 20, 2021
@nreese @kibanamachine
[Maps] fix edit layer settings action showing when readonly (elastic#…
1c43d53 
…109321)

* [Maps] fix edit layer settings action showing when readonly

* remove unneeded file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Aug 20, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 7.15
✅ 7.x
❌ 7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 109321

@nreese nreese mentioned this pull request Aug 20, 2021
Merged
@nreese
Copy link
Contributor Author

nreese commented Aug 20, 2021

7.14 #109451

kibanamachine added a commit that referenced this pull request Aug 20, 2021
@kibanamachine @nreese
[Maps] fix edit layer settings action showing when readonly (#109321) (…
887bd66 
…#109433)

* [Maps] fix edit layer settings action showing when readonly

* remove unneeded file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
kibanamachine added a commit that referenced this pull request Aug 20, 2021
@kibanamachine @nreese
[Maps] fix edit layer settings action showing when readonly (#109321) (…
f797bd0 
…#109434)

* [Maps] fix edit layer settings action showing when readonly

* remove unneeded file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.14.1 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck