[Maps] fix edit layer settings action showing when readonly (#109321) (…

…#109433) * [Maps] fix edit layer settings action showing when readonly * remove unneeded file Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
elastic · Aug 20, 2021 · 887bd66 · 887bd66
1 parent 61a993b
commit 887bd66
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 22 deletions.
diff --git a/...toc_entry/toc_entry_actions_popover/__snapshots__/toc_entry_actions_popover.test.tsx.snap b/...toc_entry/toc_entry_actions_popover/__snapshots__/toc_entry_actions_popover.test.tsx.snap
diff --git a/...layer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.tsx b/...layer_control/layer_toc/toc_entry/toc_entry_actions_popover/toc_entry_actions_popover.tsx
@@ -174,19 +174,19 @@ export class TOCEntryActionsPopover extends Component<Props, State> {
         },
       });
     }
-    actionItems.push({
-      disabled: this.props.isEditButtonDisabled,
-      name: EDIT_LAYER_SETTINGS_LABEL,
-      icon: <EuiIcon type="pencil" size="m" />,
-      'data-test-subj': 'layerSettingsButton',
-      toolTipContent: null,
-      onClick: () => {
-        this._closePopover();
-        this.props.openLayerSettings();
-      },
-    });
 
     if (!this.props.isReadOnly) {
+      actionItems.push({
+        disabled: this.props.isEditButtonDisabled,
+        name: EDIT_LAYER_SETTINGS_LABEL,
+        icon: <EuiIcon type="pencil" size="m" />,
+        'data-test-subj': 'layerSettingsButton',
+        toolTipContent: null,
+        onClick: () => {
+          this._closePopover();
+          this.props.openLayerSettings();
+        },
+      });
       if (this.state.supportsFeatureEditing) {
         actionItems.push({
           name: EDIT_FEATURES_LABEL,