Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [App Search] Convert Curations pages to new page template (#102835) #103031

Merged
merged 1 commit into from
Jun 23, 2021

Commits on Jun 23, 2021

  1. [App Search] Convert Curations pages to new page template (elastic#10…

    …2835)
    
    * Update CurationRouter
    
    - Remove breadcrumbs set in router (will get set by page template)
    - Set up a curation breadcrumb helper for DRYness
    - Remove NotFound route - curation ID 404 handling will be used instead
    
    * Convert Curations page to new page template
    + move Empty State from table to top level
    
    * Convert Curation creation page to new page template
    
    * Convert single Curation page to new page template
    
    + remove breadcrumb prop
    
    * Update router
    
    * [Polish] Copy changes from Davey
    
    - see https://github.com/elastic/kibana/pull/101958/files
    
    - Per https://elastic.github.io/eui/#/guidelines/writing we shouldn't be using "new", so I removed that also
    
    * [UI polish] Add plus icon to create button
    
    - To match other create buttons across app
    Constance authored and kibanamachine committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5f97b87 View commit details
    Browse the repository at this point in the history