Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [App Search] Convert Schema pages to new page template (#102846) #102996

Merged
merged 1 commit into from
Jun 22, 2021

Commits on Jun 22, 2021

  1. [App Search] Convert Schema pages to new page template (elastic#102846)

    * Convert Schema page to new page template
    
    + update empty state - remove panel wrapper, add create schema field modal
    
    * Convert ReindexJob view to new page template
    
    + remove breadcrumb prop
    
    * Convert Meta Engine Schema view to new page template
    
    * Update routers
    
    * [Polish] Misc Davey Schema UI tweaks
    
    - see https://github.com/elastic/kibana/pull/101958/files
    
    + change color away from secondary, since that's going away in EUI at some point
    
    * [UX] Fix SchemaAddFieldModal stuttering on first new schema field add
    
    - With the new template, transitioning from the empty state to the filled schema state causes the modal to stutter due to the component rerender
    
    - Changing the page to not instantly react/update `hasSchema` when local schema state changes but instead to wait for the server call to finish and for cachedSchema to update fixes the UX problem
    
    * [UI polish] Revert button color change per Davey's feedback
    Constance authored and kibanamachine committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7d9d0e1 View commit details
    Browse the repository at this point in the history