Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Convert Analytics views to new page template #102851

Merged
merged 4 commits into from
Jun 22, 2021
Merged

[App Search] Convert Analytics views to new page template #102851

merged 4 commits into from
Jun 22, 2021

Commits on Jun 22, 2021

  1. Convert AnalyticsHeader to AnalyticsFilters 

    - it's basically the same component as before, but without the title section/log retention tooltip, since the header/title will be handled by the new page template
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e59dfec View commit details
    Browse the repository at this point in the history

  2. Update AnalyticsLayout to use new page template 

    + add new test_helper for header children
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    da01590 View commit details
    Browse the repository at this point in the history

  3. Update breadcrumb behavior 

    - Set analytic breadcrumbs in AnalyticsLayout rather than AnalyticsRouter

- Update individual views to pass breadcrumbs (consistent with new page template API)
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    8ad3286 View commit details
    Browse the repository at this point in the history

  4. Update router

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    deb0589 View commit details
    Browse the repository at this point in the history