[App Search] Convert Analytics views to new page template #102851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it's basically the same component as before, but without the title section/log retention tooltip, since the header/title will be handled by the new page template
+ add new test_helper for header children
- Set analytic breadcrumbs in AnalyticsLayout rather than AnalyticsRouter - Update individual views to pass breadcrumbs (consistent with new page template API)
cee-chen
added
release_note:skip
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
JasonStoltz
reviewed
Jun 22, 2021
| expect(wrapper.find('[data-test-subj="world"]').text()).toEqual('World!'); | ||
|
|
||
| expect(wrapper.prop('pageChrome')).toEqual(['Engines', 'some-engine', 'Analytics']); |
There was a problem hiding this comment.
[non-blocking] It was a little confusing seeing that a pageChrome parameter accepted breadcrumbs as a parameter. I would have expected the parameter to be named something like breadcrumbs.
There was a problem hiding this comment.
Don't forget it's setting the document title too, which is very important 😄 That's why it's not just breadcrumbs, although maybe I should clarify the typing on that
JasonStoltz
approved these changes
Jun 22, 2021
JasonStoltz
approved these changes
Jun 22, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 22, 2021
…2851) * Convert AnalyticsHeader to AnalyticsFilters - it's basically the same component as before, but without the title section/log retention tooltip, since the header/title will be handled by the new page template * Update AnalyticsLayout to use new page template + add new test_helper for header children * Update breadcrumb behavior - Set analytic breadcrumbs in AnalyticsLayout rather than AnalyticsRouter - Update individual views to pass breadcrumbs (consistent with new page template API) * Update router
kibanamachine
added a commit
that referenced
this pull request
Jun 22, 2021
…102945) * Convert AnalyticsHeader to AnalyticsFilters - it's basically the same component as before, but without the title section/log retention tooltip, since the header/title will be handled by the new page template * Update AnalyticsLayout to use new page template + add new test_helper for header children * Update breadcrumb behavior - Set analytic breadcrumbs in AnalyticsLayout rather than AnalyticsRouter - Update individual views to pass breadcrumbs (consistent with new page template API) * Update router Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #102170 - converts more App Search pages to the new KibanaPageTemplate. I'm attempting to break up the AS layout conversion into smaller, easier to review chunks.
This PR handles the Analytics view. It's slightly more complex than the others as Analytics already had a shared layout/header that needed to be updated to use the new EuiPageHeader setup (the log tooltip moved to the right, which was OK'd by Davey). As always, follow along by commit (and turn off whitespace diffs)
Screencaps
Checklist