Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Convert Schema pages to new page template #102846

Merged
merged 9 commits into from
Jun 22, 2021
Merged

[App Search] Convert Schema pages to new page template #102846

merged 9 commits into from
Jun 22, 2021

Commits on Jun 22, 2021

  1. Convert Schema page to new page template 

    + update empty state - remove panel wrapper, add create schema field modal
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    86e440a View commit details
    Browse the repository at this point in the history

  2. Convert ReindexJob view to new page template 

    + remove breadcrumb prop
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    0ced8dc View commit details
    Browse the repository at this point in the history

  3. Convert Meta Engine Schema view to new page template

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c4a0695 View commit details
    Browse the repository at this point in the history

  4. Update routers

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    271ed98 View commit details
    Browse the repository at this point in the history

  5. [Polish] Misc Davey Schema UI tweaks 

    - see https://github.com/elastic/kibana/pull/101958/files

+ change color away from secondary, since that's going away in EUI at some point
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    2bed412 View commit details
    Browse the repository at this point in the history

  6. [UX] Fix SchemaAddFieldModal stuttering on first new schema field add 

    - With the new template, transitioning from the empty state to the filled schema state causes the modal to stutter due to the component rerender

- Changing the page to not instantly react/update `hasSchema` when local schema state changes but instead to wait for the server call to finish and for cachedSchema to update fixes the UX problem
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ae6335e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into kibana-page-template-as-10

    Constance committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e284370 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into kibana-page-template-as-10

    Constance committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    886803a View commit details
    Browse the repository at this point in the history

  9. [UI polish] Revert button color change per Davey's feedback

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    95c1b75 View commit details
    Browse the repository at this point in the history