Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Convert Curations pages to new page template #102835

Merged
merged 9 commits into from
Jun 23, 2021
Merged

[App Search] Convert Curations pages to new page template #102835

merged 9 commits into from
Jun 23, 2021

Commits on Jun 22, 2021

  1. Update CurationRouter 

    - Remove breadcrumbs set in router (will get set by page template)
- Set up a curation breadcrumb helper for DRYness
- Remove NotFound route - curation ID 404 handling will be used instead
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    65cf40b View commit details
    Browse the repository at this point in the history

  2. Convert Curations page to new page template 

    + move Empty State from table to top level
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    13c9312 View commit details
    Browse the repository at this point in the history

  3. Convert Curation creation page to new page template

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f8d0211 View commit details
    Browse the repository at this point in the history

  4. Convert single Curation page to new page template 

    + remove breadcrumb prop
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    a7c54c0 View commit details
    Browse the repository at this point in the history

  5. Update router

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    85b585c View commit details
    Browse the repository at this point in the history

  6. [Polish] Copy changes from Davey 

    - see https://github.com/elastic/kibana/pull/101958/files

- Per https://elastic.github.io/eui/#/guidelines/writing we shouldn't be using "new", so I removed that also
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f1502b6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into kibana-page-template-as-8

    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    5c79cc3 View commit details
    Browse the repository at this point in the history

  8. [UI polish] Add plus icon to create button 

    - To match other create buttons across app
    @cee-chen
    cee-chen committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    969daed View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into kibana-page-template-as-8

    Constance committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    21a3991 View commit details
    Browse the repository at this point in the history