[Fleet] Add assets tab #102517

jloleysens · 2021-06-17T14:51:44Z

Summary

Add the "Assets" tab to the integration details view.

How to test

Start Kibana + ES on basic
Go to fleet and follow the in-app setup instructions for getting an agent set up
Go to integrations
Choose an integration to add from the "browse" view
Note: there should be no "Assets" tab visible yet. Select "Add ",
Complete the form that just loaded (if necessary) and click "Save integration"
You should be redirected to the integrations UI (where you were before the form) with a toast containing a link
Click the link showing the "Add agent" flyout
The policy should be pre-selected (i.e., no policy selection option in the flyout, just an option to choose the enrollment token)
At the bottom of the flyout there should be a button to "View assets"
Clicking "View assets" should take you to the new "Assets" tab
(Optional) Also test clicking the "+" button when viewing the policies for an integration. This should open the same flyout as when clicking the success toast described above.

To reviewers

There is risk with this implementation that we could link to UI that does not exist/is disabled. Specifically dashboards, visualisations and discover. It seems unlikely, but the current implementation has no way of accounting for this which creates some risk. The problem already existed (see comments and restructuring of x-pack/plugins/fleet/public/hooks/use_kibana_link.ts).
Any ideas for adding tests would be appreciated! I think this is already a lot of new code to digest in a review. Ultimately I think we need functional tests to give us good coverage. I'd like to take this on in a follow up PR though if possible which means thorough manual testing is imperative!

Screenshots

Package not yet added (should be the same as before since we have not installed the package)

Success toast after adding a package with link

New flyout with "Add assets link"

New "Assets" tab with sections expanded and links implemented

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

Risk Matrix

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Some refactoring and introducing of links to external UI	Med	Med	This needs to be mitigated by using the new URL service

* added new assets screen * added routes to new assets view on the package details view

links

…t flyout

elasticmachine · 2021-06-17T14:51:46Z

Pinging @elastic/fleet (Feature:Fleet)

elasticmachine · 2021-06-17T14:51:46Z

Pinging @elastic/fleet (Team:Fleet)

kpollich

A few minor points, and one blocking question about a to-do comment. Looking great!

...s/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx

...plugins/fleet/public/applications/integrations/sections/epm/screens/detail/assets/assets.tsx

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/managed_instructions.tsx

… relevant code closer together

…ut size="l"

…ets-tab * 'master' of github.com:elastic/kibana: (93 commits) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) [Maps] clean up feature editing name space to avoid conflicts with layer settings editing (elastic#102516) [canvas] Refactor Storybook from bespoke to standard configuration (elastic#101962) [Security Solution] adds wrapSequences method (RAC) (elastic#102106) [FTR] Stabilize SSLP functional tests (elastic#102553) [K8] Added `Inter` font files for new theme (elastic#102359) [Workplace Search] Convert Groups pages to new page template (elastic#102449) [DOC] Add experimental disclaimer to rollup jobs (elastic#95624) [Security Solution][Endpoint] Suppress some of the jest console.error noise created by endpoint list middelware (elastic#102535) [Fleet] Improve performance of Fleet setup (elastic#102219) [Alerting] Add event log entry when a rule starts executing (elastic#102001) [Fleet] Update docker image of registry used in integration tests (elastic#101911) [Asset Management] Osquery telemetry updates (elastic#100754) Converts saved object tagging to new management layout (elastic#102284) ... # Conflicts: # x-pack/plugins/fleet/kibana.json

jloleysens · 2021-06-21T07:18:55Z

@elasticmachine merge upstream

kpollich

Stepped through everything locally from square one with the Nginx integration. Everything worked great! Thanks for resolving the few previous comments I had. Everything looks good to me here

kpollich · 2021-06-21T12:15:02Z

x-pack/plugins/fleet/public/hooks/use_kibana_link.ts

+  return http.basePath.prepend(`${KIBANA_BASE_PATH}#${path}`);
+};
+
+/**


Appreciate the callouts here on these stopgap solutions 👍

I've created this issue for visibility, #102740

...plugins/fleet/public/applications/integrations/sections/epm/screens/detail/assets/assets.tsx

...eet/public/applications/integrations/sections/epm/screens/detail/assets/assets_accordion.tsx

designs

jloleysens · 2021-06-21T14:02:11Z

Thanks for the review @hbharding ! I think I've addressed all of your feedback. Would you mind taking another look?

jbudz

limits.yml LGTM

dikshachauhan-qasource · 2021-06-22T11:31:58Z

Hi @EricDavisX

As per proposed functionality we have created below 05 testcases to validate the above mentioned feature.
Further,we will validate and update these cases whenever feature code merges will be available. Test cases links are as follows:

Please have a review and let us know if anything else is required.

Thanks
QAS

jloleysens · 2021-06-22T12:13:48Z

@elasticmachine merge upstream

kibanamachine · 2021-06-22T14:18:01Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	469	473	+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1013	1014	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	680.0KB	690.2KB	+10.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	439.1KB	440.6KB	+1.5KB

Unknown metric groups

API count

id	before	after	diff
`fleet`	1104	1106	+2

History

💚 Build #132735 succeeded 7ebf291
💔 Build #132700 failed dabcb2d
💚 Build #132567 succeeded 96e1d14
💔 Build #132361 failed 5800c2a
💚 Build #132118 succeeded 363e749

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jloleysens

jloleysens · 2021-06-22T15:10:30Z

@hbharding I am going to go ahead and merge this so long, happy to take on any further design feedback you have for this PR on a follow up 🍻 !

* very wip * added new assets screen * added routes to new assets view on the package details view * Finished styling the assets page layout, need to work on adding links * rather use EuiHorizontalRule * only show the assets tab if installed * Added hacky version of linking to assets. * added comment about deprecation of current linking functionality * added an initial version of the success toast with a link to the agent flyout * First iteration of end-to-end UX working. Need to add a lot of tests! * fixed navigation bug and added a comment * added a lot more padding to bottom of form * restructured code for clarity, updated deprecation comments and moved relevant code closer together * added a longer form comment about the origin policyId * added logic for handling load error * refactor assets accordions out of assets page component * slightly larger text in badge * added some basic jest test for view data step in enrollment flyout * adjusted sizing of numbers in badges again, EuiText does not know about size="l" * updated size limits for fleet * updated styling and layout of assets accordion based on original designs * remove unused EuiTitle Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-06-22T15:14:00Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* very wip * added new assets screen * added routes to new assets view on the package details view * Finished styling the assets page layout, need to work on adding links * rather use EuiHorizontalRule * only show the assets tab if installed * Added hacky version of linking to assets. * added comment about deprecation of current linking functionality * added an initial version of the success toast with a link to the agent flyout * First iteration of end-to-end UX working. Need to add a lot of tests! * fixed navigation bug and added a comment * added a lot more padding to bottom of form * restructured code for clarity, updated deprecation comments and moved relevant code closer together * added a longer form comment about the origin policyId * added logic for handling load error * refactor assets accordions out of assets page component * slightly larger text in badge * added some basic jest test for view data step in enrollment flyout * adjusted sizing of numbers in badges again, EuiText does not know about size="l" * updated size limits for fleet * updated styling and layout of assets accordion based on original designs * remove unused EuiTitle Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

dikshachauhan-qasource · 2021-07-06T13:09:33Z

Hi @EricDavisX

We have validated features on 7.14BC1 and found one issue that is not working fine.

Reported issue link on this feature is as follows:

[Fleet] Add Agent flyout not appeared on clicking 'add an agent' link displayed on success toast message while adding integration. #103266

Further, Please find test cases execution under below mentioned test run.

New Feature test run

Thanks
QAS

jloleysens added 8 commits June 17, 2021 11:04

very wip

e81acb8

* added new assets screen * added routes to new assets view on the package details view

Finished styling the assets page layout, need to work on adding

2c45e7d

links

rather use EuiHorizontalRule

815d0b6

only show the assets tab if installed

3c9912b

Added hacky version of linking to assets.

3dfd692

added comment about deprecation of current linking functionality

8669f7e

added an initial version of the success toast with a link to the agen…

646c583

…t flyout

First iteration of end-to-end UX working. Need to add a lot of tests!

f381f91

jloleysens requested a review from kpollich June 17, 2021 14:51

jloleysens requested a review from a team as a code owner June 17, 2021 14:51

jloleysens added 2 commits June 17, 2021 17:28

fixed navigation bug and added a comment

38ec56a

added a lot more padding to bottom of form

363e749

kpollich requested changes Jun 17, 2021

View reviewed changes

jen-huang assigned jloleysens Jun 17, 2021

jloleysens added 8 commits June 18, 2021 10:59

restructured code for clarity, updated deprecation comments and moved…

756a871

… relevant code closer together

added a longer form comment about the origin policyId

2bf99e0

added logic for handling load error

8f255fa

refactor assets accordions out of assets page component

fdd6fc0

slightly larger text in badge

8a1170d

added some basic jest test for view data step in enrollment flyout

38e836f

adjusted sizing of numbers in badges again, EuiText does not know abo…

f5db427

…ut size="l"

kibanamachine and others added 2 commits June 21, 2021 03:18

Merge branch 'master' into fleet/add-assets-tab

79a508e

updated size limits for fleet

96e1d14

jloleysens requested a review from a team as a code owner June 21, 2021 07:48

kpollich approved these changes Jun 21, 2021

View reviewed changes

hbharding suggested changes Jun 21, 2021

View reviewed changes

updated styling and layout of assets accordion based on original

dabcb2d

designs

jbudz approved these changes Jun 21, 2021

View reviewed changes

remove unused EuiTitle

7ebf291

Merge branch 'master' into fleet/add-assets-tab

27dc4d1

jen-huang requested a review from hbharding June 22, 2021 14:25

jloleysens merged commit 6cc3b84 into elastic:master Jun 22, 2021

jloleysens deleted the fleet/add-assets-tab branch June 22, 2021 15:10

kibanamachine mentioned this pull request Jun 22, 2021

[7.x] [Fleet] Add assets tab (#102517) #102936

Merged

criamico mentioned this pull request Oct 11, 2023

[Integrations] Show Ingest Pipelines (and other assets) under Integration Assets tab #160555

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Add assets tab #102517

[Fleet] Add assets tab #102517

jloleysens commented Jun 17, 2021 •

edited

Loading

elasticmachine commented Jun 17, 2021

elasticmachine commented Jun 17, 2021

kpollich left a comment

jloleysens commented Jun 21, 2021

kpollich left a comment

kpollich Jun 21, 2021

jloleysens Jun 21, 2021

jloleysens commented Jun 21, 2021

jbudz left a comment

dikshachauhan-qasource commented Jun 22, 2021

jloleysens commented Jun 22, 2021

kibanamachine commented Jun 22, 2021

API count

jloleysens commented Jun 22, 2021

kibanamachine commented Jun 22, 2021

dikshachauhan-qasource commented Jul 6, 2021

[Fleet] Add assets tab #102517

[Fleet] Add assets tab #102517

Conversation

jloleysens commented Jun 17, 2021 • edited Loading

Summary

How to test

To reviewers

Screenshots

Package not yet added (should be the same as before since we have not installed the package)

Success toast after adding a package with link

New flyout with "Add assets link"

New "Assets" tab with sections expanded and links implemented

Checklist

Risk Matrix

elasticmachine commented Jun 17, 2021

elasticmachine commented Jun 17, 2021

kpollich left a comment

Choose a reason for hiding this comment

jloleysens commented Jun 21, 2021

kpollich left a comment

Choose a reason for hiding this comment

kpollich Jun 21, 2021

Choose a reason for hiding this comment

jloleysens Jun 21, 2021

Choose a reason for hiding this comment

jloleysens commented Jun 21, 2021

jbudz left a comment

Choose a reason for hiding this comment

dikshachauhan-qasource commented Jun 22, 2021

jloleysens commented Jun 22, 2021

kibanamachine commented Jun 22, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

jloleysens commented Jun 22, 2021

kibanamachine commented Jun 22, 2021

💚 Backport successful

dikshachauhan-qasource commented Jul 6, 2021

jloleysens commented Jun 17, 2021 •

edited

Loading