[Workplace Search] Convert Groups pages to new page template #102449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Because dataLoading is no longer an early return, certain items need to be converted to conditional checks in order for the app to not crash
cee-chen
added
release_note:skip
yakhinvadim
approved these changes
Jun 17, 2021
Comment on lines
+84
to
+86
| const headerActions = !isFederatedAuth | ||
| ? [inviteUsersButton, createGroupButton] | ||
| : [createGroupButton]; |
There was a problem hiding this comment.
Thanks for cleaning this up!
There was a problem hiding this comment.
While we're here, just wanted to highlight that EUI's rightSideItems array is a little unintuitive at first glance - the first item (inviteUsersButton) is actually the rightmost button (matching the old JSX). Subsequent items in the array are added to the left the first item.
Maybe a moot point anyway, IIRC Scotty is removing the isFederatedAuth logic soon 🕺
- Caused by merge w/ settings subnav - useRouteMatch needs to be mocked
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2021
…#102449) * Convert Groups page to new page template * Convert Groups > Group overview to new page template - Because dataLoading is no longer an early return, certain items need to be converted to conditional checks in order for the app to not crash * Convert Groups > source prioritization to new page template * Convert Group subnav to EuiSideNav format * Update routers
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 17, 2021
#102566) * Convert Groups page to new page template * Convert Groups > Group overview to new page template - Because dataLoading is no longer an early return, certain items need to be converted to conditional checks in order for the app to not crash * Convert Groups > source prioritization to new page template * Convert Group subnav to EuiSideNav format * Update routers Co-authored-by: Constance <constancecchen@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 18, 2021
…ets-tab * 'master' of github.com:elastic/kibana: (93 commits) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) [Maps] clean up feature editing name space to avoid conflicts with layer settings editing (elastic#102516) [canvas] Refactor Storybook from bespoke to standard configuration (elastic#101962) [Security Solution] adds wrapSequences method (RAC) (elastic#102106) [FTR] Stabilize SSLP functional tests (elastic#102553) [K8] Added `Inter` font files for new theme (elastic#102359) [Workplace Search] Convert Groups pages to new page template (elastic#102449) [DOC] Add experimental disclaimer to rollup jobs (elastic#95624) [Security Solution][Endpoint] Suppress some of the jest console.error noise created by endpoint list middelware (elastic#102535) [Fleet] Improve performance of Fleet setup (elastic#102219) [Alerting] Add event log entry when a rule starts executing (elastic#102001) [Fleet] Update docker image of registry used in integration tests (elastic#101911) [Asset Management] Osquery telemetry updates (elastic#100754) Converts saved object tagging to new management layout (elastic#102284) ... # Conflicts: # x-pack/plugins/fleet/kibana.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #102170 - converts more Workplace Search pages to the new KibanaPageTemplate. I'm attempting to break up the WS layout conversion into smaller, easier to review chunks.
This PR handles the Groups pages and sub-nav. As always, follow along by commit.
Screencaps
Checklist