TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 #102494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom 7.12.1 to 7.13.0 Part of: elastic#100778
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @alexwizp |
alexwizp
added
Feature:TSVB
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
reviewed
Jun 18, 2021
| series, | ||
| esQueryConfig, | ||
| seriesIndex, | ||
| capabilities, |
There was a problem hiding this comment.
Why do we add capabilities and uiSettings? They are not used anywhere in the query function.
There was a problem hiding this comment.
Yes, this is a disgusting part of processor implementations. This is a function that accepts a sequence of arguments. So it's important for us to keep order
There was a problem hiding this comment.
Do you want to add a comment? In order to not confuse us :D
There was a problem hiding this comment.
It happens across all request/response processors. I'll create an issue to fix that
stratoula
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
LGTM, I tested it locally by migration 7.9.3 and 7.12.1 SOs that haven't defined their timefield and it works fine. I also tested 7.13.2 saved objects.
I would appreciate it if somebody else from the team could also test it thoroughly.
cc @dziyanadzeraviankina @VladLasitsa
VladLasitsa
approved these changes
Jun 18, 2021
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 18, 2021
…rom 7.12.1 to 7.13.0 (elastic#102494) * TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 Part of: elastic#100778 * fix CI
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jun 18, 2021
…rom 7.12.1 to 7.13.0 (elastic#102494) * TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 Part of: elastic#100778 * fix CI # Conflicts: # src/plugins/vis_type_timeseries/server/lib/vis_data/get_interval_and_timefield.ts # src/plugins/vis_type_timeseries/server/lib/vis_data/get_table_data.ts # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.test.js # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/table/date_histogram.js
alexwizp
added a commit
that referenced
this pull request
Jun 18, 2021
…ading from 7.12.1 to 7.13.0 (#102494) (#102645) * TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (#102494) * TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 Part of: #100778 * fix CI # Conflicts: # src/plugins/vis_type_timeseries/server/lib/vis_data/get_interval_and_timefield.ts # src/plugins/vis_type_timeseries/server/lib/vis_data/get_table_data.ts # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.test.js # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/table/date_histogram.js * fix CI
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 21, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (447 commits) skip flaky suite (elastic#102366) [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274) Add email connector info for Elastic Cloud (elastic#91363) [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663) Do not double register dashboard url generator (elastic#102599) [TSVB] Replaces EuiCodeEditor 👉 Monaco editor (elastic#100684) [Discover] Update kibana.json adding owner and description (elastic#102292) [Exploratory View] Mobile experience (elastic#99565) chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669) [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314) [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581) TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494) [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #100778
Summary
This is a follow-up PR that should fix the issue where the time field is not showing after upgrading from
7.12.1to7.13.0. Many of our users are usingTSVBwithout a configured time field. In the previous implementation, this worked because we had no separation betweenESandKibanaindexes.After
7.13.0we have 2 different modes forESandKibanaindexes. The main problem here is that there is no default time field value in theESindex. As a result, the users see a message about no data.Steps to reprocude:
Expected result: some data should be displayed
Screens
Before
After