TSVB visualizations with no timefield do not render after upgrading f…

…rom 7.12.1 to 7.13.0 (#102494)

* TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0

Part of: #100778

* fix CI

src/plugins/vis_type_timeseries/server/lib/get_vis_data.ts

@@ -38,10 +38,9 @@ export async function getVisData(
       indexPatternsService,
       uiSettings,
       searchStrategyRegistry: framework.searchStrategyRegistry,
-      cachedIndexPatternFetcher: getCachedIndexPatternFetcher(
-        indexPatternsService,
-        Boolean(panel.use_kibana_indexes)
-      ),
+      cachedIndexPatternFetcher: getCachedIndexPatternFetcher(indexPatternsService, {
+        fetchKibanaIndexForStringIndexes: Boolean(panel.use_kibana_indexes),
+      }),
     };
 
     return panel.type === PANEL_TYPES.TABLE

src/plugins/vis_type_timeseries/server/lib/search_strategies/lib/cached_index_pattern_fetcher.ts

@@ -13,12 +13,19 @@ import type { IndexPatternValue, FetchedIndexPattern } from '../../../../common/
 
 export const getCachedIndexPatternFetcher = (
   indexPatternsService: IndexPatternsService,
-  fetchKibanaIndexForStringIndexes: boolean = false
+  globalOptions: {
+    fetchKibanaIndexForStringIndexes: boolean;
+  } = {
+    fetchKibanaIndexForStringIndexes: false,
+  }
 ) => {
   const cache = new Map();
 
-  return async (indexPatternValue: IndexPatternValue): Promise<FetchedIndexPattern> => {
-    const key = getIndexPatternKey(indexPatternValue);
+  return async (
+    indexPatternValue: IndexPatternValue,
+    fetchKibanaIndexForStringIndexes: boolean = globalOptions.fetchKibanaIndexForStringIndexes
+  ): Promise<FetchedIndexPattern> => {
+    const key = `${getIndexPatternKey(indexPatternValue)}:${fetchKibanaIndexForStringIndexes}`;
 
     if (cache.has(key)) {
       return cache.get(key);

src/plugins/vis_type_timeseries/server/lib/vis_data/get_interval_and_timefield.test.ts

@@ -16,7 +16,7 @@ describe('getIntervalAndTimefield(panel, series)', () => {
     const panel = { time_field: '@timestamp', interval: 'auto' } as Panel;
     const series = {} as Series;
 
-    expect(getIntervalAndTimefield(panel, series, index)).toEqual({
+    expect(getIntervalAndTimefield(panel, index, series)).toEqual({
       timeField: '@timestamp',
       interval: 'auto',
     });
@@ -30,7 +30,7 @@ describe('getIntervalAndTimefield(panel, series)', () => {
       series_time_field: 'time',
     } as unknown) as Series;
 
-    expect(getIntervalAndTimefield(panel, series, index)).toEqual({
+    expect(getIntervalAndTimefield(panel, index, series)).toEqual({
       timeField: 'time',
       interval: '1m',
     });

src/plugins/vis_type_timeseries/server/lib/vis_data/get_interval_and_timefield.ts

@@ -7,12 +7,13 @@
  */
 
 import { AUTO_INTERVAL } from '../../../common/constants';
-import type { FetchedIndexPattern, Panel, Series } from '../../../common/types';
 import { validateField } from '../../../common/fields_utils';
 
-export function getIntervalAndTimefield(panel: Panel, series: Series, index: FetchedIndexPattern) {
+import type { FetchedIndexPattern, Panel, Series } from '../../../common/types';
+
+export function getIntervalAndTimefield(panel: Panel, index: FetchedIndexPattern, series?: Series) {
   const timeField =
-    (series.override_index_pattern ? series.series_time_field : panel.time_field) ||
+    (series?.override_index_pattern ? series.series_time_field : panel.time_field) ||
     index.indexPattern?.timeFieldName;
 
   if (panel.use_kibana_indexes) {
@@ -22,7 +23,7 @@ export function getIntervalAndTimefield(panel: Panel, series: Series, index: Fet
   let interval = panel.interval;
   let maxBars = panel.max_bars;
 
-  if (series.override_index_pattern) {
+  if (series?.override_index_pattern) {
     interval = series.series_interval || AUTO_INTERVAL;
     maxBars = series.series_max_bars;
   }

src/plugins/vis_type_timeseries/server/lib/vis_data/get_table_data.ts

@@ -25,6 +25,7 @@ import type {
   VisTypeTimeseriesVisDataRequest,
 } from '../../types';
 import type { Panel } from '../../../common/types';
+import { getIntervalAndTimefield } from './get_interval_and_timefield';
 
 export async function getTableData(
   requestContext: VisTypeTimeseriesRequestHandlerContext,
@@ -66,6 +67,18 @@ export async function getTableData(
     return panel.pivot_id;
   };
 
+  const buildSeriesMetaParams = async () => {
+    let index = panelIndex;
+
+    /** This part of code is required to try to get the default timefield for string indices.
+     *  The rest of the functionality available for Kibana indexes should not be active **/
+    if (!panel.use_kibana_indexes && index.indexPatternString) {
+      index = await services.cachedIndexPatternFetcher(index.indexPatternString, true);
+    }
+
+    return getIntervalAndTimefield(panel, index);
+  };
+
   const meta = {
     type: panel.type,
     uiRestrictions: capabilities.uiRestrictions,
@@ -78,7 +91,8 @@ export async function getTableData(
       services.esQueryConfig,
       panelIndex,
       capabilities,
-      services.uiSettings
+      services.uiSettings,
+      buildSeriesMetaParams
     );
 
     const [resp] = await searchStrategy.search(requestContext, req, [

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js

@@ -9,7 +9,6 @@
 import { overwrite } from '../../helpers';
 import { getBucketSize } from '../../helpers/get_bucket_size';
 import { offsetTime } from '../../offset_time';
-import { getIntervalAndTimefield } from '../../get_interval_and_timefield';
 import { isLastValueTimerangeMode } from '../../helpers/get_timerange_mode';
 import { search, UI_SETTINGS } from '../../../../../../../plugins/data/server';
 
@@ -22,13 +21,14 @@ export function dateHistogram(
   esQueryConfig,
   seriesIndex,
   capabilities,
-  uiSettings
+  uiSettings,
+  buildSeriesMetaParams
 ) {
   return (next) => async (doc) => {
     const maxBarsUiSettings = await uiSettings.get(UI_SETTINGS.HISTOGRAM_MAX_BARS);
     const barTargetUiSettings = await uiSettings.get(UI_SETTINGS.HISTOGRAM_BAR_TARGET);
 
-    const { timeField, interval, maxBars } = getIntervalAndTimefield(panel, series, seriesIndex);
+    const { timeField, interval, maxBars } = await buildSeriesMetaParams();
     const { from, to } = offsetTime(req, series.offset_time);
 
     let bucketInterval;

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.test.js

@@ -8,6 +8,7 @@
 
 import { DefaultSearchCapabilities } from '../../../search_strategies/capabilities/default_search_capabilities';
 import { dateHistogram } from './date_histogram';
+import { getIntervalAndTimefield } from '../../get_interval_and_timefield';
 import { UI_SETTINGS } from '../../../../../../data/common';
 
 describe('dateHistogram(req, panel, series)', () => {
@@ -18,6 +19,7 @@ describe('dateHistogram(req, panel, series)', () => {
   let config;
   let indexPattern;
   let uiSettings;
+  let buildSeriesMetaParams;
 
   beforeEach(() => {
     req = {
@@ -44,14 +46,24 @@ describe('dateHistogram(req, panel, series)', () => {
     uiSettings = {
       get: async (key) => (key === UI_SETTINGS.HISTOGRAM_MAX_BARS ? 100 : 50),
     };
+    buildSeriesMetaParams = jest.fn(async () => {
+      return getIntervalAndTimefield(panel, indexPattern, series);
+    });
   });
 
   test('calls next when finished', async () => {
     const next = jest.fn();
 
-    await dateHistogram(req, panel, series, config, indexPattern, capabilities, uiSettings)(next)(
-      {}
-    );
+    await dateHistogram(
+      req,
+      panel,
+      series,
+      config,
+      indexPattern,
+      capabilities,
+      uiSettings,
+      buildSeriesMetaParams
+    )(next)({});
 
     expect(next.mock.calls.length).toEqual(1);
   });
@@ -65,7 +77,8 @@ describe('dateHistogram(req, panel, series)', () => {
       config,
       indexPattern,
       capabilities,
-      uiSettings
+      uiSettings,
+      buildSeriesMetaParams
     )(next)({});
 
     expect(doc).toEqual({
@@ -106,7 +119,8 @@ describe('dateHistogram(req, panel, series)', () => {
       config,
       indexPattern,
       capabilities,
-      uiSettings
+      uiSettings,
+      buildSeriesMetaParams
     )(next)({});
 
     expect(doc).toEqual({
@@ -150,7 +164,8 @@ describe('dateHistogram(req, panel, series)', () => {
       config,
       indexPattern,
       capabilities,
-      uiSettings
+      uiSettings,
+      buildSeriesMetaParams
     )(next)({});
 
     expect(doc).toEqual({
@@ -197,7 +212,8 @@ describe('dateHistogram(req, panel, series)', () => {
         config,
         indexPattern,
         capabilities,
-        uiSettings
+        uiSettings,
+        buildSeriesMetaParams
       )(next)({});
 
       expect(doc.aggs.test.aggs.timeseries.auto_date_histogram).toBeUndefined();
@@ -219,7 +235,8 @@ describe('dateHistogram(req, panel, series)', () => {
         config,
         indexPattern,
         capabilities,
-        uiSettings
+        uiSettings,
+        buildSeriesMetaParams
       )(next)({});
 
       expect(doc.aggs.test.meta).toMatchInlineSnapshot(`
@@ -242,7 +259,8 @@ describe('dateHistogram(req, panel, series)', () => {
         config,
         indexPattern,
         capabilities,
-        uiSettings
+        uiSettings,
+        buildSeriesMetaParams
       )(next)({});
 
       expect(doc).toEqual({

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/positive_rate.js

@@ -7,7 +7,6 @@
  */
 
 import { getBucketSize } from '../../helpers/get_bucket_size';
-import { getIntervalAndTimefield } from '../../get_interval_and_timefield';
 import { bucketTransform } from '../../helpers/bucket_transform';
 import { overwrite } from '../../helpers';
 import { UI_SETTINGS } from '../../../../../../data/common';
@@ -58,12 +57,13 @@ export function positiveRate(
   esQueryConfig,
   seriesIndex,
   capabilities,
-  uiSettings
+  uiSettings,
+  buildSeriesMetaParams
 ) {
   return (next) => async (doc) => {
     const barTargetUiSettings = await uiSettings.get(UI_SETTINGS.HISTOGRAM_BAR_TARGET);
 
-    const { interval } = getIntervalAndTimefield(panel, series, seriesIndex);
+    const { interval } = await buildSeriesMetaParams();
     const { intervalString } = getBucketSize(req, interval, capabilities, barTargetUiSettings);
 
     if (series.metrics.some(filter)) {

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/positive_rate.test.js

@@ -12,6 +12,7 @@ describe('positiveRate(req, panel, series)', () => {
   let series;
   let req;
   let uiSettings;
+  let buildSeriesMetaParams;
 
   beforeEach(() => {
     panel = {
@@ -42,6 +43,9 @@ describe('positiveRate(req, panel, series)', () => {
     uiSettings = {
       get: async () => 50,
     };
+    buildSeriesMetaParams = jest.fn().mockResolvedValue({
+      interval: 'auto',
+    });
   });
 
   test('calls next when finished', async () => {
@@ -53,7 +57,8 @@ describe('positiveRate(req, panel, series)', () => {
       {},
       {},
       { maxBucketsLimit: 2000, getValidTimeInterval: jest.fn(() => '1d') },
-      uiSettings
+      uiSettings,
+      buildSeriesMetaParams
     )(next)({});
 
     expect(next.mock.calls.length).toEqual(1);
@@ -68,7 +73,8 @@ describe('positiveRate(req, panel, series)', () => {
       {},
       {},
       { maxBucketsLimit: 2000, getValidTimeInterval: jest.fn(() => '1d') },
-      uiSettings
+      uiSettings,
+      buildSeriesMetaParams
     )(next)({});
 
     expect(doc).toEqual({

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/query.js

@@ -7,18 +7,28 @@
  */
 
 import { offsetTime } from '../../offset_time';
-import { getIntervalAndTimefield } from '../../get_interval_and_timefield';
 import { esQuery } from '../../../../../../data/server';
 
-export function query(req, panel, series, esQueryConfig, seriesIndex) {
-  return (next) => (doc) => {
-    const { timeField } = getIntervalAndTimefield(panel, series, seriesIndex);
+export function query(
+  req,
+  panel,
+  series,
+  esQueryConfig,
+  seriesIndex,
+  capabilities,
+  uiSettings,
+  buildSeriesMetaParams
+) {
+  return (next) => async (doc) => {
+    const { timeField } = await buildSeriesMetaParams();
     const { from, to } = offsetTime(req, series.offset_time);
 
     doc.size = 0;
+
     const ignoreGlobalFilter = panel.ignore_global_filter || series.ignore_global_filter;
     const queries = !ignoreGlobalFilter ? req.body.query : [];
     const filters = !ignoreGlobalFilter ? req.body.filters : [];
+
     doc.query = esQuery.buildEsQuery(seriesIndex.indexPattern, queries, filters, esQueryConfig);
 
     const timerange = {